Hi Krzysztof, On Sun, May 1, 2022 at 10:51 AM Krzysztof Kozlowski <krzysztof.kozlowski@xxxxxxxxxx> wrote: > On 29/04/2022 15:41, Herve Codina wrote: > > Add internal PCI bridge support for the r9a06g032 SOC. The Renesas > > RZ/N1D (R9A06G032) internal PCI bridge is compatible with the one > > present in the R-Car Gen2 family. > > Compared to the R-Car Gen2 family, it needs three clocks instead of > > one. > > > > The 'resets' property for the RZ/N1 family is not required since > > there is no reset-controller support yet for the RZ/N1 family. > > This should not be a reason why a property is or is not required. Either > this is required for device operation or not. If it is required, should > be in the bindings. Otherwise what are you going to do in the future? > Add a required property breaking the ABI? The problem is that there are no bindings for the reset controller (actually the reset controller feature of the system-controller) yet. Yeah, we can just add #reset-cells = <1> to the system-controller device node, but we cannot add the actual resets properties to the consumers, until the actual cell values are defined. > > Signed-off-by: Herve Codina <herve.codina@xxxxxxxxxxx> > > Reviewed-by: Geert Uytterhoeven <geert+renesas@xxxxxxxxx> Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@xxxxxxxxxxxxxx In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds