On 29/04/2022 15:29, Ansuel Smith wrote:
Replace gcc PXO phandle to pxo_board fixed clock declared in the dts.
gcc driver doesn't provide PXO_SRC as it's a fixed-clock. This cause a
kernel panic if any driver actually try to use it.
Signed-off-by: Ansuel Smith <ansuelsmth@xxxxxxxxx>
Fixes: 40cf5c884a96 ("ARM: dts: qcom: add L2CC and RPM for IPQ8064")
It would be nice if you add Fixes tags to your patches in future. Fixes
tags allow picking up patches for stable/LTS trees.
For these two patches I'd suggest reordering them. A fix should go first
(you'll have to define pxa_board label in it). It can then be accepted
into other kernel without dependency on the other patch.
The gcc patch will come next, it will define cxo_board label and use
both clocks in the gcc node. It is not fixing a bug, so there is no need
about backporting it.
Generic rule: fixes go first (in the patch series), so that they have
minimum inter-dependencies.
---
arch/arm/boot/dts/qcom-ipq8064.dtsi | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/arch/arm/boot/dts/qcom-ipq8064.dtsi b/arch/arm/boot/dts/qcom-ipq8064.dtsi
index 9817448cfa95..ad30f7c8a5a7 100644
--- a/arch/arm/boot/dts/qcom-ipq8064.dtsi
+++ b/arch/arm/boot/dts/qcom-ipq8064.dtsi
@@ -784,7 +784,7 @@ tcsr: syscon@1a400000 {
l2cc: clock-controller@2011000 {
compatible = "qcom,kpss-gcc", "syscon";
reg = <0x2011000 0x1000>;
- clocks = <&gcc PLL8_VOTE>, <&gcc PXO_SRC>;
+ clocks = <&gcc PLL8_VOTE>, <&pxo_board>;
clock-names = "pll8_vote", "pxo";
clock-output-names = "acpu_l2_aux";
};
--
With best wishes
Dmitry
