Hi Hervé, On Thu, Apr 28, 2022 at 5:16 PM Herve Codina <herve.codina@xxxxxxxxxxx> wrote: > Add internal PCI bridge support for the r9a06g032 SOC. The Renesas > RZ/N1D (R9A06G032) internal PCI bridge is compatible with the one > present in the R-Car Gen2 family. > Compared to the R-Car Gen2 family, it needs three clocks instead of > one. > > The 'resets' property for the RZ/N1 family is not required since > there is no reset-controller support yet for the RZ/N1 family. > > Signed-off-by: Herve Codina <herve.codina@xxxxxxxxxxx> Thanks for your patch! > --- a/Documentation/devicetree/bindings/pci/renesas,pci-rcar-gen2.yaml > +++ b/Documentation/devicetree/bindings/pci/renesas,pci-rcar-gen2.yaml > +if: > + properties: > + compatible: > + contains: > + enum: > + - renesas,pci-rzn1 > + > +then: > + properties: > + clocks: > + items: > + - description: Internal bus clock (AHB) for HOST > + - description: Internal bus clock (AHB) Power Management > + - description: PCI clock for USB subsystem > + clock-names: > + items: > + - const: usb_hclkh > + - const: usb_hclkpm > + - const: usb_pciclk Please drop the "usb_" prefixes. With the above fixed: Reviewed-by: Geert Uytterhoeven <geert+renesas@xxxxxxxxx> Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@xxxxxxxxxxxxxx In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds