On 28/04/2022 18:01, Stephen Boyd wrote: >> >>> Given that none of the properties are >>> required for google,cros-ec-keyb it didn't seem necessary to make having >>> the google,cros-ec-keyb-switches compatible deny the existence of the >>> matrix-keymap properties. >> >> Maybe I misunderstood the commit msg. Are the >> "google,cros-ec-keyb-switches" devices coming with matrix keyboard or >> not? I mean physically. >> > > The answer is "sometimes, physically". Sometimes there are switches like > volume buttons and power buttons and also a matrix keyboard (convertible > and clamshells). Other times there are volume buttons and power buttons > and no matrix keyboard (detachable). This device node represents both > the keyboard and the switches. > > Unfortunately the EC firmware on older Chromebooks that don't have a > matrix keyboard still report that they have some number of columns and > rows. I was hoping to make this fully dynamic by querying the EC but > that isn't possible. OK, then it's indeed slightly different case. Let's skip my comment. Best regards, Krzysztof
