On 29/04/2022 06:10, Jason-JH Lin wrote: > Yes, we cannot have infinite number for this, but we can use not only > one mbox channel for one mmsys. > > Its maximum number is equal to GCE HW thread number. > The maximum number in mt8195 is 24 and mt8173 is 16. > > But we currently using 1. > So I'm not sure if I need to set the maxItems for this? Yes. 24 for mt8195 and 16 for mt8173. > >> >>> description: >>> - Using mailbox to communicate with GCE, it should have this >>> - property and list of phandle, mailbox specifiers. See >>> - Documentation/devicetree/bindings/mailbox/mtk-gce.txt for >>> details. >>> - $ref: /schemas/types.yaml#/definitions/phandle-array >>> + If using mailbox to communicate with GCE, it should have >>> this >>> + property. GCE will help configure the hardware settings for >>> the >>> + current mmsys data pipeline. >>> >>> mediatek,gce-client-reg: >>> - description: >>> - The register of client driver can be configured by gce with >>> 4 arguments >>> - defined in this property, such as phandle of gce, subsys id, >>> - register offset and size. >>> - Each subsys id is mapping to a base address of display >>> function blocks >>> - register which is defined in the gce header >>> - include/dt-bindings/gce/<chip>-gce.h. >>> - $ref: /schemas/types.yaml#/definitions/phandle-array >> >> Why removing ref? Does your binding work after such change? > > I removed it unexpectedly, I'll add it back. Just be sure you test it before submitting... Best regards, Krzysztof
