On Wed, Apr 27, 2022 at 02:06:00PM -0700, Doug Anderson wrote: > Hi, > > On Tue, Apr 26, 2022 at 5:03 PM Matthias Kaehlcke <mka@xxxxxxxxxxxx> wrote: > > > > Add nodes for the onboard USB hub on herobrine devices. Remove the > > 'always-on' property from the hub regulator, since the regulator > > is now managed by the onboard_usb_hub driver. > > > > Signed-off-by: Matthias Kaehlcke <mka@xxxxxxxxxxxx> > > --- > > > > Changes in v22: > > - patch added to the series > > > > .../arm64/boot/dts/qcom/sc7280-herobrine.dtsi | 21 ++++++++++++++++++- > > 1 file changed, 20 insertions(+), 1 deletion(-) > > Just like on patch #1, I presume it will be moderately annoying if > this lands in the Qualcomm branch before the driver lands in mainline? > I guess very few people have herobrine hardware, so maybe not that big > of a deal... For herobrine it's probably not a big deal, hardware isn't publicly available and those who have run it with a CrOS based kernel most of the time. But yeah, it would be somewhat annoying if USB is broken when you test something with an upstream kernel. > In any case, I'm happy with: > > Reviewed-by: Douglas Anderson <dianders@xxxxxxxxxxxx> Thanks!
