Hi Geert, Thanks for the feedback > Subject: Re: [PATCH 10/13] arm64: dts: renesas: rzg2ul-smarc: Enable > USB2.0 support > > Hi Biju, > > On Mon, Apr 25, 2022 at 7:06 PM Biju Das <biju.das.jz@xxxxxxxxxxxxxx> > wrote: > > Enable USB2.0 Host/Device support on RZ/G2L SMARC EVK by deleting the > > nodes which disabled it. > > > > Signed-off-by: Biju Das <biju.das.jz@xxxxxxxxxxxxxx> > > Reviewed-by: Lad Prabhakar <prabhakar.mahadev-lad.rj@xxxxxxxxxxxxxx> > > Thanks for your patch! > > > --- a/arch/arm64/boot/dts/renesas/r9a07g043u11-smarc.dts > > +++ b/arch/arm64/boot/dts/renesas/r9a07g043u11-smarc.dts > > @@ -20,54 +20,8 @@ &canfd { > > status = "disabled"; > > }; > > > > -&ehci0 { > > - /delete-property/ pinctrl-0; > > - /delete-property/ pinctrl-names; > > - status = "disabled"; > > -}; > > - > > -&ehci1 { > > - /delete-property/ pinctrl-0; > > - /delete-property/ pinctrl-names; > > - status = "disabled"; > > -}; > > - > > -&hsusb { > > - /delete-property/ pinctrl-0; > > - /delete-property/ pinctrl-names; > > - status = "disabled"; > > -}; > > - > > -&ohci0 { > > - /delete-property/ pinctrl-0; > > - /delete-property/ pinctrl-names; > > - status = "disabled"; > > -}; > > - > > -&ohci1 { > > - /delete-property/ pinctrl-0; > > - /delete-property/ pinctrl-names; > > - status = "disabled"; > > -}; > > Looks like lots of non-existent pinctrl properties were deleted. > Anyway, they'll be gone soon ;-) Oops. > > > --- a/arch/arm64/boot/dts/renesas/rzg2ul-smarc-pinfunction.dtsi > > +++ b/arch/arm64/boot/dts/renesas/rzg2ul-smarc-pinfunction.dtsi > > @@ -77,4 +77,15 @@ ssi1_pins: ssi1 { > > <RZG2L_PORT_PINMUX(3, 2, 2)>, /* TXD */ > > <RZG2L_PORT_PINMUX(3, 3, 2)>; /* RXD */ > > }; > > + > > + usb0_pins: usb0 { > > + pinmux = <RZG2L_PORT_PINMUX(5, 0, 1)>, /* VBUS */ > > + <RZG2L_PORT_PINMUX(5, 2, 1)>, /* OVC */ > > + <RZG2L_PORT_PINMUX(5, 3, 1)>; /* OTG_ID */ > > + }; > > + > > + usb1_pins: usb1 { > > + pinmux = <RZG2L_PORT_PINMUX(5, 4, 5)>, /* VBUS */ > > /* OVC */? > > > + <RZG2L_PORT_PINMUX(6, 0, 1)>; /* OVC */ > > /*VBUS */? OK, will fix this and send along with other 2 audio patches. Cheers, biju > > > + }; > > }; > > Gr{oetje,eeting}s, > > Geert > > -- > Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux- > m68k.org > > In personal conversations with technical people, I call myself a hacker. > But when I'm talking to journalists I just say "programmer" or something > like that. > -- Linus Torvalds