On 27/04/2022 20:08, Kamal Dasu wrote: Thank you for your patch. There is something to discuss/improve. > > clocks: > - maxItems: 1 > - description: > - handle to core clock for the sdhci controller. > + minItems: 1 > + items: > + - description: handle to core clock for the sdhci controller > + - description: improved 150Mhz clock for sdhci controller (Optional clock) > > clock-names: > + minItems: 1 > items: > - const: sw_sdio > + - const: sdio_freq # Optional clock > > sdhci,auto-cmd12: > type: boolean > description: Specifies that controller should use auto CMD12 > > +allOf: > + - $ref: mmc-controller.yaml# > + - if: > + properties: > + clock-names: > + contains: > + const: sdio_freq > + > + - then: This won't work. Please test your bindings. Best regards, Krzysztof
