Hi Piyush, Thank you for the patch! Yet something to improve: [auto build test ERROR on linus/master] [also build test ERROR on linusw-gpio/for-next linux/master v5.18-rc4 next-20220427] [If your patch is applied to the wrong git tree, kindly drop us a note. And when submitting patch, we suggest to use '--base' as documented in https://git-scm.com/docs/git-format-patch] url: https://github.com/intel-lab-lkp/linux/commits/Piyush-Malgujar/gpio-thunderx-Marvell-GPIO-changes/20220427-225001 base: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git 46cf2c613f4b10eb12f749207b0fd2c1bfae3088 config: alpha-randconfig-r005-20220427 (https://download.01.org/0day-ci/archive/20220428/202204280405.DMzMLx60-lkp@xxxxxxxxx/config) compiler: alpha-linux-gcc (GCC) 11.3.0 reproduce (this is a W=1 build): wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross chmod +x ~/bin/make.cross # https://github.com/intel-lab-lkp/linux/commit/31a85ad65112e3ed61aa418772670eb96a881a4f git remote add linux-review https://github.com/intel-lab-lkp/linux git fetch --no-tags linux-review Piyush-Malgujar/gpio-thunderx-Marvell-GPIO-changes/20220427-225001 git checkout 31a85ad65112e3ed61aa418772670eb96a881a4f # save the config file mkdir build_dir && cp config build_dir/.config COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-11.3.0 make.cross W=1 O=build_dir ARCH=alpha SHELL=/bin/bash drivers/gpio/ If you fix the issue, kindly add following tag as appropriate Reported-by: kernel test robot <lkp@xxxxxxxxx> All errors (new ones prefixed by >>): drivers/gpio/gpio-thunderx.c: In function 'thunderx_gpio_pinsel': >> drivers/gpio/gpio-thunderx.c:448:23: error: implicit declaration of function 'of_read_number' [-Werror=implicit-function-declaration] 448 | pin = of_read_number(pinsel++, 1); | ^~~~~~~~~~~~~~ cc1: some warnings being treated as errors vim +/of_read_number +448 drivers/gpio/gpio-thunderx.c 428 429 static void thunderx_gpio_pinsel(struct device *dev, 430 struct thunderx_gpio *txgpio) 431 { 432 struct device_node *node; 433 const __be32 *pinsel; 434 int npins, rlen, i; 435 u32 pin, sel; 436 437 node = dev_of_node(dev); 438 if (!node) 439 return; 440 441 pinsel = of_get_property(node, "pin-cfg", &rlen); 442 if (!pinsel || rlen % 2) 443 return; 444 445 npins = rlen / sizeof(__be32) / 2; 446 447 for (i = 0; i < npins; i++) { > 448 pin = of_read_number(pinsel++, 1); 449 sel = of_read_number(pinsel++, 1); 450 dev_dbg(dev, "Set GPIO pin %d CFG register to %x\n", pin, sel); 451 writeq(sel, txgpio->register_base + bit_cfg_reg(pin)); 452 } 453 } 454 -- 0-DAY CI Kernel Test Service https://01.org/lkp
