Re: PCI schema accepts unevaluated properties

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 27/04/2022 16:53, Rob Herring wrote:
>> I'll fix the power-domains, but dma-channels/dma-requests should not
>> fail. This should be accepted through:
>> arm,pl330.yaml -> dma-controller.yaml -> dma-common.yaml
> 
> Except that the standard property names are 'dma-channels' and
> 'dma-requests' without the '#'.
> 
> Thanks for the fixes. Unfortunately, it looks like NAND needs the same
> parent/child schema split that was done for SPI.

Oh, few drivers indeed parse '#dma-xxx' variant. For pl330 schema it was
introduced with 42cf20980cde ("ARM: dts: pl330: Add #dma-cells for
generic dma binding support")
 which clearly defines something different than uses in example. I can
imagine that editor added '#' automatically after pressing <enter> when
editing the example.

This wrong variant spread all over and in practice was not detected
because pl330 driver does not parse this field.

I'll fix it.

Best regards,
Krzysztof



[Index of Archives]     [Device Tree Compilter]     [Device Tree Spec]     [Linux Driver Backports]     [Video for Linux]     [Linux USB Devel]     [Linux PCI Devel]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [XFree86]     [Yosemite Backpacking]


  Powered by Linux