Re: [PATCH v13 3/9] mfd: qcom-spmi-pmic: read fab id on supported PMICs

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Tue, 26 Apr 2022, Caleb Connolly wrote:
> On 25/04/2022 16:05, Lee Jones wrote:
> > On Wed, 23 Mar 2022, Caleb Connolly wrote:
> > 
> > > From: Caleb Connolly <caleb.connolly@xxxxxxxxxx>
> > > 
> > > The PMI8998 and PM660 expose the fab_id, this is needed by drivers like
> > > the RRADC to calibrate ADC values.
> > > 
> > > Signed-off-by: Caleb Connolly <caleb.connolly@xxxxxxxxxx>
> > > Reviewed-by: Dmitry Baryshkov <dmitry.baryshkov@xxxxxxxxxx>
> > > Tested-by: Dmitry Baryshkov <dmitry.baryshkov@xxxxxxxxxx>
> > > ---
> > >   drivers/mfd/qcom-spmi-pmic.c      | 7 +++++++
> > >   include/soc/qcom/qcom-spmi-pmic.h | 1 +
> > >   2 files changed, 8 insertions(+)
> > 
> > Please change the Subject line to match the style of the sub-system?
> Hi, sorry if this is a silly question, I don't quite understand what you
> want me to change here, the subject line is in the same "mfd: driver:"
> format as other patches in the subsystem?

mfd: qcom-spmi-pmic: Read fab ID on supported PMICs

What's 'fab' should that be capitalised too?

> > Once changed:
> > 
> >    Acked-by: Lee Jones <lee.jones@xxxxxxxxxx>
> > 
> 

-- 
Lee Jones [李琼斯]
Principal Technical Lead - Developer Services
Linaro.org │ Open source software for Arm SoCs
Follow Linaro: Facebook | Twitter | Blog



[Index of Archives]     [Device Tree Compilter]     [Device Tree Spec]     [Linux Driver Backports]     [Video for Linux]     [Linux USB Devel]     [Linux PCI Devel]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [XFree86]     [Yosemite Backpacking]


  Powered by Linux