On 26/04/2022 09:24, Dmitry Baryshkov wrote:
> The global clock controller on apq8084 has nothing to do with the schema
> for apq8064. It uses the schema defined in qcom,gcc-other.yaml. Move
> respective declarations back.
>
> Instead add what was really meant to be present in qcom,gcc-apq8064
> schema: the compatibility string for qcom,apq8064 device.
>
Reported-by: Rob Herring <robh@xxxxxxxxxx>
> Fixes: a469bf89a009 ("dt-bindings: clock: simplify qcom,gcc-apq8064 Documentation")
> Signed-off-by: Dmitry Baryshkov <dmitry.baryshkov@xxxxxxxxxx>
> ---
> .../devicetree/bindings/clock/qcom,gcc-apq8064.yaml | 6 +++---
> Documentation/devicetree/bindings/clock/qcom,gcc-other.yaml | 3 +++
> 2 files changed, 6 insertions(+), 3 deletions(-)
>
> diff --git a/Documentation/devicetree/bindings/clock/qcom,gcc-apq8064.yaml b/Documentation/devicetree/bindings/clock/qcom,gcc-apq8064.yaml
> index 97936411b6b4..b867da12761e 100644
> --- a/Documentation/devicetree/bindings/clock/qcom,gcc-apq8064.yaml
> +++ b/Documentation/devicetree/bindings/clock/qcom,gcc-apq8064.yaml
> @@ -20,12 +20,12 @@ description: |
> See also:
> - dt-bindings/clock/qcom,gcc-msm8960.h
> - dt-bindings/reset/qcom,gcc-msm8960.h
> - - dt-bindings/clock/qcom,gcc-apq8084.h
> - - dt-bindings/reset/qcom,gcc-apq8084.h
>
> properties:
> compatible:
> - const: qcom,gcc-apq8084
> + enum:
> + - qcom,gcc-apq8064
> + - qcom,gcc-msm8060
This looks wrong. msm8060 was not broken by that commit and was never
here, was it?
Best regards,
Krzysztof
