Hi Stephen, > > diff --git a/drivers/net/ethernet/sunplus/spl2sw_driver.h > > b/drivers/net/ethernet/sunplus/spl2sw_driver.h > > new file mode 100644 > > index 000000000..5f177b3af > > --- /dev/null > > +++ b/drivers/net/ethernet/sunplus/spl2sw_driver.h > > @@ -0,0 +1,12 @@ > > +/* SPDX-License-Identifier: GPL-2.0 */ > > +/* Copyright Sunplus Technology Co., Ltd. > > + * All rights reserved. > > + */ > > + > > +#ifndef __SPL2SW_DRIVER_H__ > > +#define __SPL2SW_DRIVER_H__ > > + > > +#define SPL2SW_RX_NAPI_WEIGHT 16 > > +#define SPL2SW_TX_NAPI_WEIGHT 16 > > Why define your own? there is NAPI_POLL_WEIGHT already defined in netdevice.h I didn't know there is NAPI_POLL_WEIGHT defined in netdevice.h. I'll remove my own define and use it next patch. Thank you for your review. Best regards, Wells