On Mon, Apr 25, 2022 at 04:05:57PM +0200, David Heidelberg wrote: > On 25/04/2022 15:51, Krzysztof Kozlowski wrote: > > On 25/04/2022 15:47, David Heidelberg wrote: > > > Adds forgotten compatible and update SPDX header. > > You need to explain what is this "forgotten compatible". It's to vague. > Forgotten by someone who implemented it in driver. Hope that clarify it for > you and possibly other readers. Btw. qcom,*sm8450* compatibles are widely > used and fact that `make dtbs_check` noticed it missing here isn't > suprising.. > > > > The SPDX update lacks answer to "why". There is no reason to do it, so > > please explain why it is needed. > > Please read https://spdx.org/licenses/GPL-2.0.html (red colored text). > > I personally encountered situation, where usage GPL license without specific > `-only` or `-or-later` caused unnecessary confusion and uncertainty. I don't mind changing these, but please do a tree wide change for all bindings, not an 'while I'm here also change X' change. Rob
