On Thu, Apr 21, 2022 at 02:21:27PM -0500, nick.hawkins@xxxxxxx wrote: > From: Nick Hawkins <nick.hawkins@xxxxxxx> > > Add the hpe gxp watchdog timer binding hpe,gxp-wdt. > This will enable support for the HPE GXP Watchdog. > > Signed-off-by: Nick Hawkins <nick.hawkins@xxxxxxx> > > --- > v5: > * Fixed version log > v4: > * Made watchdog a child of timer because of same register > area based on review feedback > * Simplified the watchdog yaml as it will get information > from parent device > v3: > * Used proper patchset format. > v2: > * Converted from txt to yaml > --- > .../bindings/watchdog/hpe,gxp-wdt.yaml | 30 +++++++++++++++++++ > 1 file changed, 30 insertions(+) > create mode 100644 Documentation/devicetree/bindings/watchdog/hpe,gxp-wdt.yaml > > diff --git a/Documentation/devicetree/bindings/watchdog/hpe,gxp-wdt.yaml b/Documentation/devicetree/bindings/watchdog/hpe,gxp-wdt.yaml > new file mode 100644 > index 000000000000..c20da146352f > --- /dev/null > +++ b/Documentation/devicetree/bindings/watchdog/hpe,gxp-wdt.yaml > @@ -0,0 +1,30 @@ > +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) > +%YAML 1.2 > +--- > +$id: http://devicetree.org/schemas/watchdog/hpe,gxp-wdt.yaml# > +$schema: http://devicetree.org/meta-schemas/core.yaml# > + > +title: HPE GXP Controlled Watchdog > + > +allOf: > + - $ref: "watchdog.yaml#" > + > +maintainers: > + - Nick Hawkins <nick.hawkins@xxxxxxx> > + - Jean-Marie Verdun <verdun@xxxxxxx> > + > +properties: > + compatible: > + const: hpe,gxp-wdt > + > +required: > + - compatible > + > +unevaluatedProperties: false > + > +examples: > + - | > + watchdog0: watchdog { > + compatible = "hpe,gxp-wdt"; How is this h/w controlled? I'm guessing it's part of the timer? If so, you don't need this node. A single node can implement multiple functions. Rob