Hi Geert, Thanks for the feedback. > Subject: Re: [PATCH] dt-bindings: i2c: renesas,riic: Document RZ/G2UL SoC > > Hi Biju, > > On Sat, Apr 23, 2022 at 3:20 PM Biju Das <biju.das.jz@xxxxxxxxxxxxxx> > wrote: > > Document RZ/G2UL I2C bindings. RZ/G2UL I2C is identical to one found > > on the RZ/G2L SoC. No driver changes are required as RZ/G2L compatible > > string "renesas,riic-rz" will be used as a fallback. > > > > Signed-off-by: Biju Das <biju.das.jz@xxxxxxxxxxxxxx> > > Thanks for your patch! > > > --- a/Documentation/devicetree/bindings/i2c/renesas,riic.yaml > > +++ b/Documentation/devicetree/bindings/i2c/renesas,riic.yaml > > @@ -19,6 +19,7 @@ properties: > > - enum: > > - renesas,riic-r7s72100 # RZ/A1H > > - renesas,riic-r7s9210 # RZ/A2M > > + - renesas,riic-r9a07g043 # RZ/G2UL > > - renesas,riic-r9a07g044 # RZ/G2{L,LC} > > - renesas,riic-r9a07g054 # RZ/V2L > > - const: renesas,riic-rz # RZ/A or RZ/G2L > > You forgot to make the resets property required on RZ/G2UL. Oops, Will fix it in V2. Cheers, Biju > > With that fixes: > Reviewed-by: Geert Uytterhoeven <geert+renesas@xxxxxxxxx> > > Gr{oetje,eeting}s, > > Geert > > -- > Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux- > m68k.org > > In personal conversations with technical people, I call myself a hacker. > But when I'm talking to journalists I just say "programmer" or something > like that. > -- Linus Torvalds