Hi Krzysztof,
On 23/04/22 4:02 pm, Krzysztof Kozlowski wrote:
> On 22/04/2022 08:50, Vignesh Raghavendra wrote:
>> Add nodes for I2C IO expander, OSPI Flash, Eth PHYs, SD and eMMC that
>> are present on AM625 SK board.
>>
>> Signed-off-by: Vignesh Raghavendra <vigneshr@xxxxxx>
>> Reviewed-by: Bryan Brattlof <bb@xxxxxx>
>> ---
>> arch/arm64/boot/dts/ti/k3-am625-sk.dts | 273 +++++++++++++++++++++++++
>> 1 file changed, 273 insertions(+)
>>
>> diff --git a/arch/arm64/boot/dts/ti/k3-am625-sk.dts b/arch/arm64/boot/dts/ti/k3-am625-sk.dts
>> index 0de4113ccd5de..5fc35898a1e2e 100644
>> --- a/arch/arm64/boot/dts/ti/k3-am625-sk.dts
>> +++ b/arch/arm64/boot/dts/ti/k3-am625-sk.dts
>> @@ -9,6 +9,7 @@
>>
>> #include <dt-bindings/leds/common.h>
>> #include <dt-bindings/gpio/gpio.h>
>> +#include <dt-bindings/net/ti-dp83867.h>
>> #include "k3-am625.dtsi"
>>
>> / {
>> @@ -17,6 +18,12 @@ / {
>>
>> aliases {
>> serial2 = &main_uart0;
>> + mmc0 = &sdhci0;
>> + mmc1 = &sdhci1;
>> + mmc2 = &sdhci2;
>> + spi0 = &ospi0;
>> + ethernet0 = &cpsw_port1;
>> + ethernet1 = &cpsw_port2;
>> };
>>
>> chosen {
>> @@ -87,6 +94,33 @@ vcc_3v3_sys: regulator-2 {
>> regulator-boot-on;
>> };
>>
>> + vdd_mmc1: fixed-regulator-sd {
>
> Don't encode the type of binding into node name. Node name should be
> generic, so either regulator-0 or regulator-sd.
>
>> + /* TPS22918DBVR */
>> + compatible = "regulator-fixed";
>> + regulator-name = "vdd_mmc1";
>> + regulator-min-microvolt = <3300000>;
>> + regulator-max-microvolt = <3300000>;
>> + regulator-boot-on;
>> + enable-active-high;
>> + vin-supply = <&vcc_3v3_sys>;
>> + gpio = <&exp1 3 GPIO_ACTIVE_HIGH>;
>> + };
>> +
>> + vdd_sd_dv: gpio-regulator-TLV71033 {
>
> The same + do not mix cases, so regulator-1 or regulator-tlv71033
I have fixed this in v3. But had one question though:
Per DT spec, 2.2.3 Path Names seems to indicate node-name-N when N is
1,2,3.. So, is it valid to have regulator-tlv71033 as node-name -> does
not strictly seem to fit into node-name-N format ?
Regards
Vignesh
