Re: [PATCH] arm64: dts: allwinner: teres-i: Add GPIO port regulators

[Samuel Holland <samuel@xxxxxxxxxxxx>]

On 4/15/22 11:56 AM, Harald Geyer wrote:
> Allwinner A64 SoC has separate supplies for PC, PD, PE, PG and PL.
> 
> Usually supplies are linked via the 'regulator-name' property of
> regulator nodes. However when regulators are shared we need to
> declare the additional links in the pinctrl node.
> 
> Signed-off-by: Harald Geyer <harald@xxxxxxxxx>

I'm curious if this solved an issue for you, or if this is just for accuracy.
Both of these regulators have the regulator-always-on property, so they should
have been enabled already. If it's the latter reason, why not add the other
ports? Regardless:

Reviewed-by: Samuel Holland <samuel@xxxxxxxxxxxx>

> ---
>  arch/arm64/boot/dts/allwinner/sun50i-a64-teres-i.dts | 5 +++++
>  1 file changed, 5 insertions(+)
> 
> diff --git a/arch/arm64/boot/dts/allwinner/sun50i-a64-teres-i.dts b/arch/arm64/boot/dts/allwinner/sun50i-a64-teres-i.dts
> index aff0660b899c..cc316ef2e2d6 100644
> --- a/arch/arm64/boot/dts/allwinner/sun50i-a64-teres-i.dts
> +++ b/arch/arm64/boot/dts/allwinner/sun50i-a64-teres-i.dts
> @@ -197,6 +197,11 @@ &ohci1 {
>  	status = "okay";
>  };
>  
> +&pio {
> +	vcc-pc-supply = <&reg_dcdc1>;
> +	vcc-pg-supply = <&reg_aldo2>;
> +};
> +
>  &pwm {
>  	status = "okay";
>  };
>