On 21/04/2022 21:21, nick.hawkins@xxxxxxx wrote: > From: Nick Hawkins <nick.hawkins@xxxxxxx> > > This adds support for the hpe,gxp binding. Just "Add support for HPE GXP". https://elixir.bootlin.com/linux/v5.17.1/source/Documentation/process/submitting-patches.rst#L95 > The GXP is based on > the cortex a9 processor and supports arm7. > > Signed-off-by: Nick Hawkins <nick.hawkins@xxxxxxx> > > --- > v5: > * Fix version log > v4: > * Removed gxp.yaml > * Created hpe,gxp.yaml based on reviewer input > v3: > * Created gxp.yaml > v2: > * No change > --- > .../devicetree/bindings/arm/hpe,gxp.yaml | 22 +++++++++++++++++++ > 1 file changed, 22 insertions(+) > create mode 100644 Documentation/devicetree/bindings/arm/hpe,gxp.yaml > > diff --git a/Documentation/devicetree/bindings/arm/hpe,gxp.yaml b/Documentation/devicetree/bindings/arm/hpe,gxp.yaml > new file mode 100644 > index 000000000000..cd86b67ea207 > --- /dev/null > +++ b/Documentation/devicetree/bindings/arm/hpe,gxp.yaml > @@ -0,0 +1,22 @@ > +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) > +%YAML 1.2 > +--- > +$id: http://devicetree.org/schemas/arm/hpe,gxp.yaml# > +$schema: http://devicetree.org/meta-schemas/core.yaml# > + > +title: HPE BMC GXP SoC driver This is not a SoC driver anymore, so instead maybe: "HPE BMC GXP SoC platforms" or "HPE BMC GXP platforms" > + > +maintainers: > + - Nick Hawkins <nick.hawkins@xxxxxxx> > + - Jean-Marie Verdun <verdun@xxxxxxx> > + > +properties: > + compatible: You do not allow any extension of this (no oneOf), which is fine if you do not plan any other SoCs or SoMs. This is okay, but if there is a chance list will grow, then you should have here oneOf, like other bindings. > + items: > + - enum: > + - hpe,gxp-dl360gen10 > + - const: hpe,gxp > + > +additionalProperties: true > + > +... Best regards, Krzysztof
