On 21/04/2022 21:21, nick.hawkins@xxxxxxx wrote: > diff --git a/Documentation/devicetree/bindings/timer/hpe,gxp-timer.yaml b/Documentation/devicetree/bindings/timer/hpe,gxp-timer.yaml > new file mode 100644 > index 000000000000..a4572be8d89a > --- /dev/null > +++ b/Documentation/devicetree/bindings/timer/hpe,gxp-timer.yaml > @@ -0,0 +1,49 @@ > +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) > +%YAML 1.2 > +--- > +$id: http://devicetree.org/schemas/timer/hpe,gxp-timer.yaml# > +$schema: http://devicetree.org/meta-schemas/core.yaml# > + > +title: HPE GXP TIMER s/TIMER/Timer/ > + > +maintainers: > + - Nick Hawkins <nick.hawkins@xxxxxxx> > + - Jean-Marie Verdun <verdun@xxxxxxx> > + > +properties: > + compatible: > + items: > + - const: hpe,gxp-timer > + - const: simple-mfd > + > + reg: > + maxItems: 1 > + > + interrupts: > + maxItems: 1 > + > + clocks: > + maxItems: 1 > + > + clock-names: > + const: iopclk s/iopclk/iop/ > + > +required: > + - compatible > + - reg > + - interrupts > + - clocks > + - clock-names > + > +additionalProperties: true This has to be false and you need to define the children (since you use simple-mfd). > + > +examples: > + - | > + timer0: timer@c0000000 { > + compatible = "hpe,gxp-timer","simple-mfd"; Missing space after ','. > + reg = <0x80 0x16>; > + interrupts = <0>; > + interrupt-parent = <&vic0>; > + clocks = <&iopclk>; > + clock-names = "iopclk"; > + }; Best regards, Krzysztof
