On Mon, Sep 15, 2014 at 2:34 AM, Pantelis Antoniou <panto@xxxxxxxxxxxxxxxxxxxxxxx> wrote: > Hi Gaurav, > > > On Sep 13, 2014, at 3:35 PM, Gaurav Minocha wrote: > >> This patch is used to remove the selftests dependency on >> OF_DYNAMIC config flag. Now, it selectively builds only >> the functions required by the selftests. >> >> Tested with and without OF_DYNAMIC enabled. >> >> Signed-off-by: Gaurav Minocha <gaurav.minocha.os@xxxxxxxxx> >> --- > > [snip] > > I'm not happy with this patch. > > It duplicates core functionality already present in drivers/of/dynamic.c and those > two implementations are for sure going to get out of sync. I understand your point, but I did this after discussing with Grant. > > If you require the self-tests to work without OF_DYNAMIC you can do that by including the > tests in your dts. If you want to insert them dynamically then use OF_DYNAMIC. So, according to above, selftest should not attach test data dynamically if the OF_DYNAMIC symbol is disabled. Correct me if wrong. I will discuss and update the patch as appropriate. Thanks! > > Regards > > -- Pantelis > -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
