From: Santosh Shilimkar <santosh.shilimkar@xxxxxx>
Date: Sat, 13 Sep 2014 16:07:18 -0400
> + /* Find this module in the sub-tree for this device */
> + devices = of_get_child_by_name(node, "netcp-devices");
> + if (!devices) {
> + dev_err(dev, "could not find netcp-devices node\n");
> + return NETCP_MOD_PROBE_SKIPPED;
> + }
> +
> + for_each_available_child_of_node(devices, child) {
> + const char *name = netcp_node_name(child);
> +
> + if (!strcasecmp(module->name, name))
> + break;
> + }
> +
> + /* If module not used for this device, skip it */
> + if (child == NULL) {
> + dev_warn(dev, "module(%s) not used for device\n", module->name);
> + return NETCP_MOD_PROBE_SKIPPED;
> + }
of_get_child_by_name() takes a reference to an OF node, you must release
it in the error path.
> + inst_modpriv = devm_kzalloc(dev, sizeof(*inst_modpriv), GFP_KERNEL);
> + if (!inst_modpriv) {
> + dev_err(dev, "Failed to allocate instance for %s\n",
> + module->name);
> + return -ENOMEM;
> + }
Likewise, but here you have to release both "devices" and "child".
You're going to have to fix this OF node refcount problem for this
entire probe routine.
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
