Re: [PATCH v6, 5/5] dt-bindings: pwm: Add interrupts property for MediaTek MT8192

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Thu, Apr 21, 2022 at 03:48:08PM +0200, Uwe Kleine-König wrote:
> Hello,
> 
> On Thu, Apr 21, 2022 at 12:17:00PM +0200, AngeloGioacchino Del Regno wrote:
> > Il 18/04/22 14:20, xinlei.lee@xxxxxxxxxxxx ha scritto:
> > > From: Xinlei Lee <xinlei.lee@xxxxxxxxxxxx>
> > > 
> > > Add interrupts property of pwm for MediaTek MT8192 SoC.
> > > 
> > > Signed-off-by: Xinlei Lee <xinlei.lee@xxxxxxxxxxxx>
> > 
> > Hello Xinlei,
> > the pwm-mtk-disp.c driver does not support interrupts.
> > 
> > Please add interrupts support to the driver first, and only then
> > add that in the dt-bindings.
> 
> in my understanding the linux driver state and the binding documentation
> are somewhat independent. Here I'd say adding the irq information to dt
> without the driver supporting it is fine.

Agreed. I've applied this along with the rest. It doesn't have Rob's or
Krzysztof's stamp of approval, but it's a trivial change and looks fine
to me.

Thierry

Attachment: signature.asc
Description: PGP signature


[Index of Archives]     [Device Tree Compilter]     [Device Tree Spec]     [Linux Driver Backports]     [Video for Linux]     [Linux USB Devel]     [Linux PCI Devel]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [XFree86]     [Yosemite Backpacking]


  Powered by Linux