On 22/04/2022 09:15, Tinghan Shen wrote: > This patch adds mt8186 dsp document. The dsp is used for Sound Open > Firmware driver node. It includes registers, clocks, memory regions, > and mailbox for dsp. > > Signed-off-by: Tinghan Shen <tinghan.shen@xxxxxxxxxxxx> > --- > > This patch depends on MT8186 clock bindings. > https://lore.kernel.org/all/20220409132251.31725-2-chun-jie.chen@xxxxxxxxxxxx/ > > --- > .../bindings/dsp/mediatek,mt8186-dsp.yaml | 93 +++++++++++++++++++ > 1 file changed, 93 insertions(+) > create mode 100644 Documentation/devicetree/bindings/dsp/mediatek,mt8186-dsp.yaml > > diff --git a/Documentation/devicetree/bindings/dsp/mediatek,mt8186-dsp.yaml b/Documentation/devicetree/bindings/dsp/mediatek,mt8186-dsp.yaml > new file mode 100644 > index 000000000000..00a79e880895 > --- /dev/null > +++ b/Documentation/devicetree/bindings/dsp/mediatek,mt8186-dsp.yaml > @@ -0,0 +1,93 @@ > +# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause) > +%YAML 1.2 > +--- > +$id: http://devicetree.org/schemas/dsp/mediatek,mt8186-dsp.yaml# > +$schema: http://devicetree.org/meta-schemas/core.yaml# > + > +title: Mediatek mt8186 DSP core > + > +maintainers: > + - Tinghan Shen <tinghan.shen@xxxxxxxxxxxx> > + > +description: | > + MediaTek mt8186 SoC contains a DSP core used for > + advanced pre- and post- audio processing. > + > +properties: > + compatible: > + const: mediatek,mt8186-dsp > + > + reg: > + items: > + - description: Address and size of the DSP config registers > + - description: Address and size of the DSP SRAM > + - description: Address and size of the DSP secure registers > + - description: Address and size of the DSP bus registers > + > + reg-names: > + items: > + - const: cfg > + - const: sram > + - const: sec > + - const: bus > + > + clocks: > + items: > + - description: mux for audio dsp clock > + - description: mux for audio dsp local bus > + > + clock-names: > + items: > + - const: audiodsp_sel > + - const: adsp_bus_sel What does the "sel" stands for? Maybe just skip the "_sel" suffixes? > + > + power-domains: > + maxItems: 1 > + > + mboxes: > + items: > + - description: ipc reply between host and audio DSP. > + - description: ipc request between host and audio DSP. > + > + mbox-names: > + items: > + - const: mbox0 > + - const: mbox1 These should be rather some meaningful names, e.g. "rx" and "tx". > + > + memory-region: > + items: > + - description: dma buffer between host and DSP. > + - description: DSP system memory. > + > +required: > + - compatible > + - reg > + - reg-names > + - clocks > + - clock-names > + - power-domains > + - mbox-names > + - mboxes > + > +additionalProperties: false > + > +examples: > + - | > + #include <dt-bindings/interrupt-controller/arm-gic.h> > + #include <dt-bindings/interrupt-controller/irq.h> You do not use these headers. > + #include <dt-bindings/clock/mt8186-clk.h> > + dsp@10680000 { Best regards, Krzysztof
