On 19/04/2022 18:21, Vincent Knecht wrote:
Hi Bryan, thanks for this much awaited dtsi :-) Some comments below, maybe more once I get around to testing it... Le mardi 19 avril 2022 à 02:09 +0100, Bryan O'Donoghue a écrit :+ cpr_opp_table: cpr-opp-table { + compatible = "operating-points-v2-qcom-level";Just curious : am I missing something, that I don't see this compatible defined anywhere outside binding docs and qcs404.dtsi ?
Not yet but, we do reuse that in 8939 and will be necessary for any other SoC with CPR we do.
+ apcs1_mbox: mailbox@b011000 { + compatible = "qcom,msm8916-apcs-kpss-global"; + reg = <0xb011000 0x1000>; + #mbox-cells = <1>; + clocks = <&a53pll_c1>, <&gcc GPLL0_VOTE>, <&xo_board>; + clock-names = "pll", "aux", "ref"; + #clock-cells = <0>; + clock-output-names = "a53mux_c1"; + /* Set a nominal frequency on a53mux_cci */ + assigned-clocks = <&apcs2>; + assigned-clock-rates = <297600000>; + }; + + apcs1: syscon@b111000 { + compatible = "syscon"; + reg = <0xb011000 0x1000>; + }; +Is it okay that unit and reg addresses don't match ?
Prima face, not in the slightest typo/bug. Thanks for the pointers on the lk2nd matching. --- bod
