Re: [PATCH v5 2/2] dt-bindings: timer: Add compatible for am6 for TI timer-dm

Grygorii Strashko <grygorii.strashko@xxxxxx> · Mon, 18 Apr 2022 15:22:06 +0300

On 14/04/2022 11:58, Tony Lindgren wrote:
Let's add compatible for ti,am654-timer for TI am64, am65 and j72 SoCs.
As the timer hardware is the same between am64, am65 and j72 we use the
compatible name for the earliest SoC with this timer.

The timer interrupts are not routable for the operating system for some
timers on am6. Let's make sure the interrupts are configured for the
timers on all other SoCs.

Cc: Daniel Lezcano <daniel.lezcano@xxxxxxxxxx>
Cc: Grygorii Strashko <grygorii.strashko@xxxxxx>
Cc: Keerthy <j-keerthy@xxxxxx>
Cc: Nishanth Menon <nm@xxxxxx>
Cc: Vignesh Raghavendra <vigneshr@xxxxxx>
Acked-by: Krzysztof Kozlowski <krzysztof.kozlowski@xxxxxxxxxx>
Signed-off-by: Tony Lindgren <tony@xxxxxxxxxxx>
---
  .../devicetree/bindings/timer/ti,timer-dm.yaml       | 12 +++++++++++-
  1 file changed, 11 insertions(+), 1 deletion(-)

diff --git a/Documentation/devicetree/bindings/timer/ti,timer-dm.yaml b/Documentation/devicetree/bindings/timer/ti,timer-dm.yaml
--- a/Documentation/devicetree/bindings/timer/ti,timer-dm.yaml
+++ b/Documentation/devicetree/bindings/timer/ti,timer-dm.yaml
@@ -19,6 +19,7 @@ properties:
            - enum:
                - ti,am335x-timer
                - ti,am335x-timer-1ms
+              - ti,am654-timer
                - ti,dm814-timer
                - ti,dm816-timer
                - ti,omap2420-timer
@@ -88,11 +89,20 @@ properties:
  required:
    - compatible
    - reg
-  - interrupts
  
  additionalProperties: false
  
  allOf:
+  - if:
+      not:
+        properties:
+          compatible:
+            contains:
+              const: ti,am654-timer
+    then:
+      required:
+        - interrupts
+
    - if:
        not:
          properties:

Thanks you,
Reviewed-by: Grygorii Strashko <grygorii.strashko@xxxxxx>

--
Best regards,
Grygorii, Ukraine






