> > +static int a5psw_probe_mdio(struct a5psw *a5psw) > > +{ > > + struct device *dev = a5psw->dev; > > + struct device_node *mdio_node; > > + struct mii_bus *bus; > > + int err; > > + > > + if (of_property_read_u32(dev->of_node, "clock-frequency", > > + &a5psw->mdio_freq)) > > + a5psw->mdio_freq = A5PSW_MDIO_DEF_FREQ; > > Shouldn't the clock-frequency be a property of the "mdio" node? > At least I see it in Documentation/devicetree/bindings/net/mdio.yaml. Yes. And the example in the binding document for this driver also places it in the mdio node. Andrew