On Thu, Apr 14, 2022 at 02:44:00PM +0100, Bryan O'Donoghue wrote: > On 14/04/2022 14:00, Sakari Ailus wrote: > > > ret = clk_prepare_enable(imx412->inclk); > > > if (ret) { > > > + regulator_bulk_disable(imx412->num_supplies, > > > + imx412->supplies); > > As the function already has an error handling section using labels, this > > should go there as well. > > > Are you asking to move regulator_bulk_disable() to error_reset ? No. You'll need another label. -- Sakari Ailus