On Tue, 12 Apr 2022 at 21:43, Stephen Boyd <sboyd@xxxxxxxxxx> wrote: > > Quoting Dmitry Baryshkov (2022-04-06 12:57:30) > > On Wed, 6 Apr 2022 at 18:40, Stephen Boyd <sboyd@xxxxxxxxxx> wrote: > > > > > > Quoting Dmitry Baryshkov (2022-04-05 17:26:44) > > > > Currently gcc-msm8960 driver manually creates tsens device. Instantiate > > > > the device using DT node instead. This follow the IPQ8064 device tree > > > > schema. > > > > > > Why can't the schema be changed? > > > > But these commits change the schema. They make apq8064 follow more > > logical scheme of ipq8064. > > > > Sounds like ipq8064 and apq8064 follow different schemas. Is there any > benefit to harmonizing the two vs. just leaving it as it is in the dts > and making the schema match whatever the dts has? I'd prefer to harmonize them. It makes no sense to have two different approaches for the single IP block (shared between ipq and apq/msm). And having a separate device tree node for the tsens removes a dependency from gcc on the nvmem/qfprom. Note, upstream qcom-msm8960.dtsi doesn't describe tsens at all, so we don't have to worry about it. -- With best wishes Dmitry
