On 11/04/2022 12:03, Camel Guo wrote: > From: Camel Guo <camelg@xxxxxxxx> > > Document the TMP401, TMP411 and TMP43x device devicetree bindings > > Signed-off-by: Camel Guo <camelg@xxxxxxxx> > --- > .../devicetree/bindings/hwmon/ti,tmp401.yaml | 111 ++++++++++++++++++ > MAINTAINERS | 1 + > 2 files changed, 112 insertions(+) > create mode 100644 Documentation/devicetree/bindings/hwmon/ti,tmp401.yaml > Thank you for your patch. There is something to discuss/improve. > diff --git a/Documentation/devicetree/bindings/hwmon/ti,tmp401.yaml b/Documentation/devicetree/bindings/hwmon/ti,tmp401.yaml > new file mode 100644 > index 000000000000..28be5cbb009b > --- /dev/null > +++ b/Documentation/devicetree/bindings/hwmon/ti,tmp401.yaml > @@ -0,0 +1,111 @@ > +# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause) > +%YAML 1.2 > +--- > +$id: http://devicetree.org/schemas/hwmon/ti,tmp401.yaml# > +$schema: http://devicetree.org/meta-schemas/core.yaml# > + > +title: TMP401, TPM411 and TMP43x temperature sensor > + > +maintainers: > + - Guenter Roeck <linux@xxxxxxxxxxxx> > + > +description: | > + ±1°C Remote and Local temperature sensor > + > + Datasheets: > + https://www.ti.com/lit/ds/symlink/tmp401.pdf > + https://www.ti.com/lit/ds/symlink/tmp411.pdf > + https://www.ti.com/lit/ds/symlink/tmp431.pdf > + https://www.ti.com/lit/ds/symlink/tmp435.pdf > + > +properties: > + compatible: > + enum: > + - ti,tmp401 > + - ti,tmp411 > + - ti,tmp431 > + - ti,tmp432 > + - ti,tmp435 Blank line, please. > + reg: > + maxItems: 1 > + > + '#address-cells': > + const: 1 > + > + '#size-cells': > + const: 0 > + > + ti,extended-range-enable: > + description: | No need for "|". Here and in most of other cases below. > + When set, this sensor measures over extended temperature range. > + type: boolean > + > + ti,n-factor: > + description: | > + The value (two's complement) to be programmed in the n-factor correction > + register. Do not describe the programming model (registers) but hardware property instead. > + $ref: /schemas/types.yaml#/definitions/uint32 > + items: > + minimum: 0 > + maximum: 255 > + > + ti,beta-compensation: > + description: | > + The value to be programmed in the beta range register. The same, register values should not be stored in DT. > + $ref: /schemas/types.yaml#/definitions/uint32 > + items: > + minimum: 0 > + maximum: 15 > + Best regards, Krzysztof
