On 12/04/2022 11:48, Krzysztof Kozlowski wrote:
> EXTERNAL EMAIL: Do not click links or open attachments unless you know the content is safe
>
> On 11/04/2022 10:59, Conor Dooley wrote:
>> The rtc on PolarFire SoC does not use the AHB clock as its reference
>> frequency, but rather a 1 MHz refclk that it shares with MTIMER. Add
>> this second clock to the binding as a required property.
>>
>> Fixes: 4cbcc0d7b397 ("dt-bindings: rtc: add bindings for microchip mpfs rtc")
>> Reviewed-by: Daire McNamara <daire.mcnamara@xxxxxxxxxxxxx>
>> Signed-off-by: Conor Dooley <conor.dooley@xxxxxxxxxxxxx>
>> ---
>> .../bindings/rtc/microchip,mfps-rtc.yaml | 14 +++++++++++---
>> 1 file changed, 11 insertions(+), 3 deletions(-)
>>
>> diff --git a/Documentation/devicetree/bindings/rtc/microchip,mfps-rtc.yaml b/Documentation/devicetree/bindings/rtc/microchip,mfps-rtc.yaml
>> index a2e984ea3553..1ffd97dbe6b9 100644
>> --- a/Documentation/devicetree/bindings/rtc/microchip,mfps-rtc.yaml
>> +++ b/Documentation/devicetree/bindings/rtc/microchip,mfps-rtc.yaml
>> @@ -31,11 +31,18 @@ properties:
>> to that of the RTC's count register.
>>
>> clocks:
>> - maxItems: 1
>> + items:
>> + - description: |
>> + AHB clock
>> + - description: |
>> + Reference clock: divided by the prescaler to create a time-based strobe (typically 1 Hz)
>> + for the calendar counter. By default, the rtc on the PolarFire SoC shares it's reference
>> + with MTIMER so this will be a 1 MHz clock.
>
> Please wrap it at 80-column, it is still preferred coding style. The
> same in your patch 4/9.
Sure, will do :)
>
> Acked-by: Krzysztof Kozlowski <krzysztof.kozlowski@xxxxxxxxxx>
>
>
> Best regards,
> Krzysztof
