On 11/04/2022 10:59, Conor Dooley wrote:
> The RTC reference and MSSPLL were previously not documented or defined,
> as they were unused. Add their defines to the PolarFire SoC header.
>
> Fixes: 2145bb687e3f ("dt-bindings: clk: microchip: Add Microchip PolarFire host binding")
> Reviewed-by: Daire McNamara <daire.mcnamara@xxxxxxxxxxxxx>
> Signed-off-by: Conor Dooley <conor.dooley@xxxxxxxxxxxxx>
> ---
> include/dt-bindings/clock/microchip,mpfs-clock.h | 5 ++++-
> 1 file changed, 4 insertions(+), 1 deletion(-)
>
> diff --git a/include/dt-bindings/clock/microchip,mpfs-clock.h b/include/dt-bindings/clock/microchip,mpfs-clock.h
> index 73f2a9324857..3cba46b9191f 100644
> --- a/include/dt-bindings/clock/microchip,mpfs-clock.h
> +++ b/include/dt-bindings/clock/microchip,mpfs-clock.h
> @@ -1,15 +1,18 @@
> /* SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) */
> /*
> * Daire McNamara,<daire.mcnamara@xxxxxxxxxxxxx>
> - * Copyright (C) 2020 Microchip Technology Inc. All rights reserved.
> + * Copyright (C) 2020-2022 Microchip Technology Inc. All rights reserved.
> */
>
> #ifndef _DT_BINDINGS_CLK_MICROCHIP_MPFS_H_
> #define _DT_BINDINGS_CLK_MICROCHIP_MPFS_H_
>
> +#define CLK_MSSPLL 34
You have some weird order here. Shouldn't it be under CLK_RTCREF?
> +
> #define CLK_CPU 0
> #define CLK_AXI 1
> #define CLK_AHB 2
> +#define CLK_RTCREF 33
>
> #define CLK_ENVM 3
> #define CLK_MAC0 4
Best regards,
Krzysztof
