Re: [PATCH 1/2] dt-bindings: timer: Update TI timer to yaml

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi,

* Krzysztof Kozlowski <krzysztof.kozlowski@xxxxxxxxxx> [220412 08:58]:
> On 11/04/2022 13:18, Tony Lindgren wrote:
> > Some timers on some SoCs are dual mapped, like the ABE timers on omap4
> > and 5. The reg property maxItems must be updated to 2.

So on omap4/5 there are timers with a single IO register and with
dual mapped IO registers.

> (...)
> 
> > +  reg:
> > +    minItems: 1
> > +    maxItems: 2
> > +    description: Timer IO register range
> > +
> 
> Apart from what Grygorii said, it would be useful if you add "if:then:"
> case constraining it per implementation (as I understood from commit msg
> only some use double mapping).
> 
> This looks like:
> https://elixir.bootlin.com/linux/v5.18-rc2/source/Documentation/devicetree/bindings/clock/samsung,exynos7885-clock.yaml#L53

Yes I tried, but see the above. The compatible property is the same for
single mapped and dual mapped timers on the same SoC for omap4/5.

> Similarly should be done for clocks, unless it's impossible (same
> compatible uses different setups of clocks).

It's the same situation for clocks, the same compatible is used for
timers with one clock and timers with two clocks for example on dra7.

I'll check the description again to clarify this, maybe it's not
clear yet.

> BTW, it's a bit confusing it is not a v2...

Oops sorry looks like I forgot to update the version.

Regards,

Tony



[Index of Archives]     [Device Tree Compilter]     [Device Tree Spec]     [Linux Driver Backports]     [Video for Linux]     [Linux USB Devel]     [Linux PCI Devel]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [XFree86]     [Yosemite Backpacking]


  Powered by Linux