On Mon, 28 Mar 2022 10:09, AngeloGioacchino Del Regno <angelogioacchino.delregno@xxxxxxxxxxxxx> wrote: >Il 28/03/22 00:39, Guillaume Ranquet ha scritto: >> From: Markus Schneider-Pargmann <msp@xxxxxxxxxxxx> >> >> Similar to HDMI, DP uses audio infoframes as well which are structured >> very similar to the HDMI ones. >> >> This patch adds a helper function to pack the HDMI audio infoframe for >> DP, called hdmi_audio_infoframe_pack_for_dp(). >> hdmi_audio_infoframe_pack_only() is split into two parts. One of them >> packs the payload only and can be used for HDMI and DP. >> >> Signed-off-by: Markus Schneider-Pargmann <msp@xxxxxxxxxxxx> >> Signed-off-by: Guillaume Ranquet <granquet@xxxxxxxxxxxx> >> --- >> drivers/video/hdmi.c | 82 ++++++++++++++++++++++++++-------- >> include/drm/dp/drm_dp_helper.h | 2 + >> include/linux/hdmi.h | 7 ++- >> 3 files changed, 71 insertions(+), 20 deletions(-) >> >> diff --git a/drivers/video/hdmi.c b/drivers/video/hdmi.c >> index 947be761dfa4..5f50237554ed 100644 >> --- a/drivers/video/hdmi.c >> +++ b/drivers/video/hdmi.c >> @@ -21,6 +21,7 @@ >> * DEALINGS IN THE SOFTWARE. >> */ >> >> +#include <drm/dp/drm_dp_helper.h> >> #include <linux/bitops.h> >> #include <linux/bug.h> >> #include <linux/errno.h> >> @@ -381,12 +382,34 @@ static int hdmi_audio_infoframe_check_only(const struct hdmi_audio_infoframe *fr >> * >> * Returns 0 on success or a negative error code on failure. >> */ >> -int hdmi_audio_infoframe_check(struct hdmi_audio_infoframe *frame) >> +int hdmi_audio_infoframe_check(const struct hdmi_audio_infoframe *frame) > >I agree with this change, as hdmi_audio_infoframe_check_only()'s param is a const, >but you really should mention that you're constifying this one in your commit >description, or do that in a separate commit. > >Either of the two is fine. > >Regards, >Angelo Noted, I'll add it to the commit message. Thx, Guillaume.
