On 4/11/22 18:46, Lucas Stach wrote:
Am Montag, dem 11.04.2022 um 00:11 +0200 schrieb Marek Vasut:
On 4/7/22 11:12, Lucas Stach wrote:
Am Donnerstag, dem 07.04.2022 um 01:43 +0200 schrieb Marek Vasut:
On 4/6/22 17:33, Lucas Stach wrote:
[...]
+static const struct imx8mp_blk_ctrl_data imx8mp_hsio_blk_ctl_dev_data = {
+ .max_reg = 0x24,
Doesn't the HSIO_BLK_CTL go up to 0x10c ?
Technically yes, but there is already a driver for the USB glue
(fsl,imx8mp-dwc3) that occupies the USB registers at and above 0x100.
Shouldn't that imx8mp-dwc3 glue code be switched to syscon and access
the registers through this driver then ?
I don't see why this would be needed. Registers up to 0x24 are a mixed
bag of blk-ctrls, but the registers above 0x100 are only USB wakeup
related, I don't see the blk-ctrl ever wanting to touch them.
I think the current split is fine. Just because the RM lumps those
register regions together into the HSIO blk-ctrl description doesn't
mean we need to cover them all in a single syscon.
I guess we can also always fix this up later, OK.
