> > > diff --git a/arch/arm64/boot/dts/qcom/sc7280-herobrine.dtsi b/arch/arm64/boot/dts/qcom/sc7280-herobrine.dtsi
> > > index de646d9..c6a04c3 100644
> > > --- a/arch/arm64/boot/dts/qcom/sc7280-herobrine.dtsi
> > > +++ b/arch/arm64/boot/dts/qcom/sc7280-herobrine.dtsi
> > > @@ -20,6 +20,14 @@
> > > #include "sc7280-chrome-common.dtsi"
> > > / {
> > > + max98360a: audio-codec-0 {
> > > + compatible = "maxim,max98360a";
> > > + pinctrl-names = "default";
> > > + pinctrl-0 = <&_en>;
> > > + sdmode-gpios = <&tlmm 63 GPIO_ACTIVE_HIGH>;
> > > + #sound-dai-cells = <0>;
> > > + };
> > > +
> > This node shouldn't be at top but with the other device nodes, in
> > alphabetical order, i.e. before 'pwmleds'.
>
> Actually we are sorting as per node name. Hence kept it here. As per
> previous reviewer comments, sorted accordingly.
>
> Please suggest better approach.
True, I forgot the node names are used for sorting, not the labels.
> > > diff --git a/arch/arm64/boot/dts/qcom/sc7280.dtsi b/arch/arm64/boot/dts/qcom/sc7280.dtsi
> > > index db74fc3..78ec84c 100644
> > > --- a/arch/arm64/boot/dts/qcom/sc7280.dtsi
> > > +++ b/arch/arm64/boot/dts/qcom/sc7280.dtsi
> > > @@ -822,6 +822,127 @@
> > > #power-domain-cells = <1>;
> > > };
> > > + rxmacro: codec@3200000 {
> > These node are not at the correct position. They should be sorted by
> > address and hence be inserted between 'lpasscc@3000000' and
> > 'interconnect@3c40000'.
>
> Actually we are sorting as per node(codec) name. Hence kept it here. As per
> previous reviewer comments, sorted accordingly.
Could you provide a pointer to those comments?
My understanding is that we are sorting by node name when nodes don't have
addresses or for overrides in board files/snippets, however the nodes under
'soc@0' are sorted by address.
Another nit: 'rx_macro, tx_macro, va_macro' instead of the labels without
underscore? Not really important, but maybe slightly more readable and
would match the 'spelling' of the compatible strings.
