Will do. Thanks Neil.
G
-----Original Message-----
From: Neil Armstrong <narmstrong@xxxxxxxxxxxx>
Sent: April 11, 2022 10:21 AM
To: Guillaume Giraudon <ggiraudon@xxxxxxxxxxx>; kernel-dev@xxxxxxxxxxx
Cc: Rob Herring <robh+dt@xxxxxxxxxx>; Krzysztof Kozlowski <krzk+dt@xxxxxxxxxx>; Kevin Hilman <khilman@xxxxxxxxxxxx>; Jerome Brunet <jbrunet@xxxxxxxxxxxx>; Martin Blumenstingl <martin.blumenstingl@xxxxxxxxxxxxxx>; devicetree@xxxxxxxxxxxxxxx; linux-arm-kernel@xxxxxxxxxxxxxxxxxxx; linux-amlogic@xxxxxxxxxxxxxxxxxxx; linux-kernel@xxxxxxxxxxxxxxx
Subject: Re: [PATCH RESEND] arm64: dts: meson-sm1-bananapi-m5: fix wrong GPIO pin labeling for CON1
Hi,
On 11/04/2022 16:04, Guillaume Giraudon wrote:
> The labels for lines 61 through 84 on the periphs-banks were offset by 2.
> Realigned them to match the Banana Pi M5 schematics.
>
> Fixes: 976e920183e4 ("arm64: dts: meson-sm1: add Banana PI BPI-M5
> board dts")
>
> Signed-off-by: Guillaume Giraudon <ggiraudon@xxxxxxxxxxx>
> ---
> arch/arm64/boot/dts/amlogic/meson-sm1-bananapi-m5.dts | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/arch/arm64/boot/dts/amlogic/meson-sm1-bananapi-m5.dts
> b/arch/arm64/boot/dts/amlogic/meson-sm1-bananapi-m5.dts
> index 5751c48620ed..754c3d43ef0b 100644
> --- a/arch/arm64/boot/dts/amlogic/meson-sm1-bananapi-m5.dts
> +++ b/arch/arm64/boot/dts/amlogic/meson-sm1-bananapi-m5.dts
> @@ -448,7 +448,7 @@
> "",
> /* GPIOA */
> "", "", "", "", "", "", "", "",
> - "", "", "", "", "", "",
> + "", "", "", "", "", "", "", "",
> "CON1-P27", /* GPIOA_14 */
> "CON1-P28", /* GPIOA_15 */
> /* GPIOX */
While reviewing more closely I figured that in fact the issue comes from the :
/* BOOT */
"eMMC_D0", /* BOOT_0 */
"eMMC_D1", /* BOOT_1 */
"eMMC_D2", /* BOOT_2 */
"eMMC_D3", /* BOOT_3 */
"eMMC_D4", /* BOOT_4 */
"eMMC_D5", /* BOOT_5 */
"eMMC_D6", /* BOOT_6 */
"eMMC_D7", /* BOOT_7 */
"eMMC_CLK", /* BOOT_8 */
"",
"eMMC_CMD", /* BOOT_10 */
"",
"eMMC_RST#", /* BOOT_12 */
"eMMC_DS", /* BOOT_13 */
/* GPIOC */
it contains 14 entries, but there is 16 BOOT gpio lines.
So instead, send a V2 with 2 entries added in BOOT and leave the GPIOA entries as-is.
Thanks,
Neil
