Hello Geert, On 4/11/22 15:35, Geert Uytterhoeven wrote: > Hi Chen-Yu, [snip] >> --- a/Documentation/devicetree/bindings/display/solomon,ssd1307fb.yaml >> +++ b/Documentation/devicetree/bindings/display/solomon,ssd1307fb.yaml >> @@ -13,6 +13,7 @@ maintainers: >> properties: >> compatible: >> enum: >> + - sinowealth,sh1106-i2c > > Please don't introduce new compatible values including the bus type. > There is no need for that, and this will only lead to more deprecated > compatible values soon... > > Oops, this is already commit 97a40c23cda5d64a ("dt-bindings: > display: ssd1307fb: Add entry for SINO WEALTH SH1106") in > drm-misc/for-linux-next... > Yeah, too late :/ I didn't think it would be controversial at the time. -- Best regards, Javier Martinez Canillas Linux Engineering Red Hat