Re: [PATCH] ARM: dts: Drop unused ti,am4372-timer compatible

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 





On 08/04/2022 11:33, Krzysztof Kozlowski wrote:
On 08/04/2022 10:29, Tony Lindgren wrote:
* Krzysztof Kozlowski <krzysztof.kozlowski@xxxxxxxxxx> [220408 08:22]:
On 08/04/2022 10:12, Tony Lindgren wrote:
Drop unused (and undocumented) ti,am4372-timer related compatible
properties to avoid dtb warnings when updating the binding to yaml.

The dual-mode timer instances on am43 are compatible with the am3
timers.

Are you sure this is correct approach? Maybe some other user of DTS
references the am43 compatible, so instead it should be documented in
the bindings?

No users.

You sure you check all operating systems and all out-of-tree users? I
did not talk about in-kernel DTS...

The driver does not parse these. The am4 SoCs boot using
the am3 related compatible properties.

See also recommendation "DO use fallback compatibles...":
Documentation/devicetree/bindings/writing-bindings.rst
which maybe applies here?

Yes I'd agree if there were users for this, or if this was already
documented :) But I don't see a need to keep these am4 specific
properties.


I'd prefer to drop it if not used and not documented.
conversation to yaml is good time for clean up.
if somebody complains - can always return back and document it.

--
Best regards,
Grygorii, Ukraine



[Index of Archives]     [Device Tree Compilter]     [Device Tree Spec]     [Linux Driver Backports]     [Video for Linux]     [Linux USB Devel]     [Linux PCI Devel]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [XFree86]     [Yosemite Backpacking]


  Powered by Linux