Hi Chuanhong, gch981213@xxxxxxxxx wrote on Thu, 7 Apr 2022 23:06:48 +0800: > this code will be used in mediatek snfi spi-mem controller with > pipelined ECC engine. > > Signed-off-by: Chuanhong Guo <gch981213@xxxxxxxxx> > --- > > Change since v1: > actually make it a module instead of a part of nandcore.o > (ECC_MXIC probablly needs a similar fix.) Please do not hesitate to propose something about it. Otherwise on the MTD side the series looks good (besides the two comments you already received). I don't know if something changed regarding the comments style in the spi subsystem, but using // everywhere looks strange, it's usually reserved for the SPDX tag, but I'll let Mark comment on it. Otherwise, MTD patches 1 and 3 look fine. Thanks, Miquèl
