On Thu, 2022-04-07 at 17:24 -0400, Nícolas F. R. A. Prado wrote: > Hi Jiaxin, > > On Wed, Apr 06, 2022 at 06:05:12PM +0800, Jiaxin Yu wrote: > > MT8192 platform will use rt1015 or rt1015p codec, so through the > > snd_soc_of_get_dai_link_codecs() to complete the configuration > > of dai_link's codecs. > > Suggestion for the commit message: > > As part of the refactoring to allow the same machine driver to be > used for the > rt1015(p) and rt5682(s) codecs on the MT8192 platform, parse the > rt1015(p) > codecs from the speaker-codecs property in the devicetree and wire > them to the > I2S3 backend, instead of hardcoding the links and selecting through > the > compatible. > Hi Nícolas, I will update the commit message according to the rule of one row per 75 columns. I will also refer to your suggestions to modify the rest of the series. Thanks for your review. Jiaxin.Yu Thanks. > > > > Signed-off-by: Jiaxin Yu <jiaxin.yu@xxxxxxxxxxxx> > > Reviewed-by: Nícolas F. R. A. Prado <nfraprado@xxxxxxxxxxxxx> > Tested-by: Nícolas F. R. A. Prado <nfraprado@xxxxxxxxxxxxx> > > - Tested on mt8192-asurada-spherion (rt1015p and rt5682). All audio > paths still > work as previous to this refactor. And it's still possible to omit > mediatek,hdmi-codec. > > Thanks, > Nícolas
