Re: [PATCH] [v2]arm64: dts: qcom: Add sc7180-gelarshie

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Thu, 7 Apr 2022 at 09:54, Mars Chen
<chenxiangrui@xxxxxxxxxxxxxxxxxxxxxxxxxxxxxx> wrote:
>
> Add device tree for Gelarshie, a trogdor variant
>
> Signed-off-by: Mars Chen <chenxiangrui@xxxxxxxxxxxxxxxxxxxxxxxxxxxxxx>

Your subject is incorrect. Please use `git format-patch -v2`. You
still did not provide a changelog (put under ---) against v1. You
still did not reply to my comments and did not implement them.
https://lore.kernel.org/linux-devicetree/a0eb6bf9-256a-29b1-2211-496df710f531@xxxxxxxxxx/

If they are unclear, please respond to them, so I can clarify. However
you did not respond but resent without implementing them, so it looks
like you ignore the comments.

This is not a good process. :(

Please read again:
https://elixir.bootlin.com/linux/v5.18-rc1/source/Documentation/process/submitting-patches.rst#L307

I am sorry, but I have to NAK the patch till you respond to my comments.

Best regards,
Krzysztof



[Index of Archives]     [Device Tree Compilter]     [Device Tree Spec]     [Linux Driver Backports]     [Video for Linux]     [Linux USB Devel]     [Linux PCI Devel]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [XFree86]     [Yosemite Backpacking]


  Powered by Linux