Hi Caesar,
Am Mittwoch, 10. September 2014, 10:49:05 schrieb Caesar Wang:
> Hi Heiko,
>
> 在 2014年09月09日 19:37, Heiko Stübner 写道:
> > Am Mittwoch, 3. September 2014, 10:10:38 schrieb Caesar Wang:
> >> Signed-off-by: Caesar Wang <caesar.wang@xxxxxxxxxxxxxx>
> >> ---
> >>
> >> arch/arm/boot/dts/rk3288.dtsi | 18 ++++++++++++++++++
> >> 1 file changed, 18 insertions(+)
> >>
> >> diff --git a/arch/arm/boot/dts/rk3288.dtsi
> >> b/arch/arm/boot/dts/rk3288.dtsi
> >> index 36be7bb..3d672e3 100644
> >> --- a/arch/arm/boot/dts/rk3288.dtsi
> >> +++ b/arch/arm/boot/dts/rk3288.dtsi
[...]
> >> @@ -611,5 +622,12 @@
> >>
> >> rockchip,pins = <5 15 3 &pcfg_pull_none>;
> >>
> >> };
> >>
> >> };
> >>
> >> +
> >> + tsadc {
> >> + tsadc_int: tsadc-int {
> >> + rockchip,pins = <0 10 RK_FUNC_1 &pcfg_pull_up>;
> >> + };
> >> + };
> >
> > After looking this up in the schematics I see that this is the
> > overtemperature-protection output pin ... labeled OTP_OUT.
> > So I'd think the pinconfig should reflect this pin-name, especially as
> > tsadc-int suggests, that this would be an interrupt leading into the
> > tsadc, while in fact it is an output to a separate circuit.
>
> Maybe,I guess your mean as the follows .
> Please correct it and Laugh out if I got it wrong.
I'll never laugh ... just try get the best solution / trying to understand
backgrounds.
>
> tsadc {
> otp_out: otp-out {
> rockchip,pins = <0 10 RK_FUNC_GPIO &pcfg_pull_none>;
> };
>
> tsadc_int: tsadc-int {
> rockchip,pins = <0 10 RK_FUNC_1 &pcfg_pull_none>;
> };
> };
> Then,I deal with the otp_out in thermal driver.
> I believe The "otp_out" will restart board if it's a high active.
>
> tsadc_int: tsadc-int {
> + rockchip,pins = <0 10 RK_FUNC_1 &pcfg_pull_up>;
> + };
>
> But,I think the about will be implemented in thermal driver.
I only meant the pin name (tsadc-int -> otp-out). In the schmatics the pin
(controlled by the tsadc) is labeled otp_out and leads to the overtemperature
protection circuit as expected. And as it's controlled by the tsadc, it should
of course stay as the desired func_1.
Heiko
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
