Re: [PATCH v4 07/11] soc: imx: add i.MX8MP HDMI blk-ctrl

[Marek Vasut <marex@xxxxxxx>]

On 4/6/22 17:33, Lucas Stach wrote:

[...]

> +static void imx8mp_hdmi_blk_ctrl_power_on(struct imx8mp_blk_ctrl *bc,
> +					  struct imx8mp_blk_ctrl_domain *domain)
> +{
> +	switch (domain->id) {
> +	case IMX8MP_HDMIBLK_PD_IRQSTEER:
> +		regmap_set_bits(bc->regmap, HDMI_RTX_CLK_CTL0, BIT(9));
> +		regmap_set_bits(bc->regmap, HDMI_RTX_RESET_CTL0, BIT(16));
> +		break;
> +	case IMX8MP_HDMIBLK_PD_LCDIF:
> +		regmap_set_bits(bc->regmap, HDMI_RTX_CLK_CTL0,
> +				BIT(7) | BIT(16) | BIT(17) | BIT(18) |
> +				BIT(19) | BIT(20));
> +		regmap_set_bits(bc->regmap, HDMI_RTX_CLK_CTL1, BIT(11));
> +		regmap_set_bits(bc->regmap, HDMI_RTX_RESET_CTL0,
> +				BIT(4) | BIT(5) | BIT(6));

Macros which define all those ad-hoc bits might be nice.

[...]