Quoting Mark Brown (2022-04-06 08:45:41) > On Wed, Apr 06, 2022 at 08:23:11AM -0700, Stephen Boyd wrote: > > Quoting Mark Brown (2022-04-06 00:31:45) > > > > It's a MFD function driver isn't it? > > > The DT binding shows a single i2c node at i2c address 0x9. The > > compatible for it is "qcom,pm8008-regulators". It looks like an i2c > > device that is dedicated to providing regulators. I'd only expect to see > > an MFD if the device responding at i2c address 0x9 supported more than > > just regulators. > > There's a MFD parent for it, and if it's for an I2C device for a pm8008 > why would it have a -regulators in the name? There are two i2c devices. One is pm8008 at i2c address 0x8 and one is pm8008-regulators at i2c address 0x9. Earlier revisions of this patch series were making it very confusing by redoing the pm8008 binding and adding the pm8008-regulator i2c address device to the same binding and driver. My guess is that this is one IC that responds to multiple i2c addresses. The "main" qcom,pm8008 address is 0x8 and that supports things like interrupts. Then there's an address for regulators at 0x9 which controls the handful of LDOs on the PMIC.