Re: [PATCH 2/3] dt-bindings: clock: Document MA35D1 clock controller bindings

[Jacky Huang <ychuang3@xxxxxxxxxxx>]

On 2022/3/31 下午 02:27, Krzysztof Kozlowski wrote:
> On 31/03/2022 04:42, Jacky Huang wrote:
> > Add documentation to describe Nuvoton MA35D1 clock driver bindings.
> >
> > Signed-off-by: Jacky Huang <ychuang3@xxxxxxxxxxx>
> > ---
> >   .../bindings/clock/nuvoton,ma35d1-clk.yaml    | 59 +++++++++++++++++++
> >   1 file changed, 59 insertions(+)
> >   create mode 100644 Documentation/devicetree/bindings/clock/nuvoton,ma35d1-clk.yaml
> >
> > diff --git a/Documentation/devicetree/bindings/clock/nuvoton,ma35d1-clk.yaml b/Documentation/devicetree/bindings/clock/nuvoton,ma35d1-clk.yaml
> > new file mode 100644
> > index 000000000000..bf5474b10420
> > --- /dev/null
> > +++ b/Documentation/devicetree/bindings/clock/nuvoton,ma35d1-clk.yaml
> > @@ -0,0 +1,59 @@
> > +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
> > +%YAML 1.2
> > +---
> > +$id: https://apc01.safelinks.protection.outlook.com/?url=http%3A%2F%2Fdevicetree.org%2Fschemas%2Fclock%2Fnuvoton%2Cma35d1-clk.yaml%23&amp;data=04%7C01%7Cychuang3%40nuvoton.com%7C26d072d904854cb7c77308da12df8dd5%7Ca3f24931d4034b4a94f17d83ac638e07%7C0%7C0%7C637843048619482176%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000&amp;sdata=NgdR0%2F8%2BxsM4u%2BPuKtuniulNf%2BhMLJoYsjIPnR0iVec%3D&amp;reserved=0
> > +$schema: https://apc01.safelinks.protection.outlook.com/?url=http%3A%2F%2Fdevicetree.org%2Fmeta-schemas%2Fcore.yaml%23&amp;data=04%7C01%7Cychuang3%40nuvoton.com%7C26d072d904854cb7c77308da12df8dd5%7Ca3f24931d4034b4a94f17d83ac638e07%7C0%7C0%7C637843048619482176%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000&amp;sdata=Km%2Fawm8lT0IYN39tkE3lSrho9uCOd2Fgs8qb82pI7ec%3D&amp;reserved=0
> > +
> > +title: Nuvoton MA35D1 Clock Control Module Binding
> > +
> > +maintainers:
> > +  - Chi-Fang Li <cfli0@xxxxxxxxxxx>
> > +  - Jacky Huang <ychuang3@xxxxxxxxxxx>
> > +
> > +description: |
> > +  The MA35D1 clock controller generates clocks for the whole chip,
> > +  including system clocks and all peripheral clocks.
> > +
> > +  See also:
> > +    dt-bindings/clock/ma35d1-clk.h
> Full path needed.

I will fix it as include/dt-bindings/clock/ma35d1-clk.h
> > +
> > +properties:
> > +  compatible:
> > +    const: nuvoton,ma35d1-clk
> > +
> > +  reg:
> > +    maxItems: 1
> > +
> > +  "#clock-cells":
> > +    const: 1
> > +
> > +  clocks:
> > +    maxItems: 1
> > +
> > +  assigned-clocks:
> > +    maxItems: 4
> > +
> > +  assigned-clock-rates:
> > +    maxItems: 4
> > +
> > +  clock-pll-mode:
> > +    maxItems: 4
> > +
> > +required:
> > +  - compatible
> > +  - reg
> > +  - "#clock-cells"
> > +
> > +additionalProperties: false
> > +
> > +examples:
> > +  # clock control module node:
> Useless comment, remove it.

OK, I will remove it.

> Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@xxxxxxxxxx>
>
> Best regards,
> Krzysztof

Thanks for your review.

Sincerely,
Jacky