Hi Wells, I love your patch! Yet something to improve: [auto build test ERROR on net/master] [also build test ERROR on robh/for-next linus/master v5.18-rc1 next-20220405] [cannot apply to net-next/master] [If your patch is applied to the wrong git tree, kindly drop us a note. And when submitting patch, we suggest to use '--base' as documented in https://git-scm.com/docs/git-format-patch] url: https://github.com/intel-lab-lkp/linux/commits/Wells-Lu/This-is-a-patch-series-for-Ethernet-driver-of-Sunplus-SP7021-SoC/20220404-040949 base: https://git.kernel.org/pub/scm/linux/kernel/git/davem/net.git 692930cc435099580a4b9e32fa781b0688c18439 config: alpha-randconfig-c004-20220405 (https://download.01.org/0day-ci/archive/20220406/202204060616.kl1yKwP5-lkp@xxxxxxxxx/config) compiler: alpha-linux-gcc (GCC) 11.2.0 reproduce (this is a W=1 build): wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross chmod +x ~/bin/make.cross # https://github.com/intel-lab-lkp/linux/commit/d8d2085594ea52869669a553bb6d60e0b3a1f412 git remote add linux-review https://github.com/intel-lab-lkp/linux git fetch --no-tags linux-review Wells-Lu/This-is-a-patch-series-for-Ethernet-driver-of-Sunplus-SP7021-SoC/20220404-040949 git checkout d8d2085594ea52869669a553bb6d60e0b3a1f412 # save the config file to linux build tree mkdir build_dir COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-11.2.0 make.cross O=build_dir ARCH=alpha SHELL=/bin/bash If you fix the issue, kindly add following tag as appropriate Reported-by: kernel test robot <lkp@xxxxxxxxx> All errors (new ones prefixed by >>): drivers/pinctrl/sunplus/sppctl.c: In function 'sppctl_gpio_new': >> drivers/pinctrl/sunplus/sppctl.c:559:14: error: 'struct gpio_chip' has no member named 'of_gpio_n_cells' 559 | gchip->of_gpio_n_cells = 2; | ^~ -- drivers/net/ethernet/sunplus/spl2sw_driver.c: In function 'spl2sw_get_eth_child_node': >> drivers/net/ethernet/sunplus/spl2sw_driver.c:328:9: error: implicit declaration of function 'for_each_child_of_node'; did you mean 'for_each_online_node'? [-Werror=implicit-function-declaration] 328 | for_each_child_of_node(ether_np, port_np) { | ^~~~~~~~~~~~~~~~~~~~~~ | for_each_online_node >> drivers/net/ethernet/sunplus/spl2sw_driver.c:328:50: error: expected ';' before '{' token 328 | for_each_child_of_node(ether_np, port_np) { | ^~ | ; drivers/net/ethernet/sunplus/spl2sw_driver.c:326:13: warning: unused variable 'port_id' [-Wunused-variable] 326 | int port_id; | ^~~~~~~ drivers/net/ethernet/sunplus/spl2sw_driver.c:342:1: error: no return statement in function returning non-void [-Werror=return-type] 342 | } | ^ drivers/net/ethernet/sunplus/spl2sw_driver.c: In function 'spl2sw_probe': >> drivers/net/ethernet/sunplus/spl2sw_driver.c:407:24: error: implicit declaration of function 'of_get_child_by_name' [-Werror=implicit-function-declaration] 407 | eth_ports_np = of_get_child_by_name(pdev->dev.of_node, "ethernet-ports"); | ^~~~~~~~~~~~~~~~~~~~ drivers/net/ethernet/sunplus/spl2sw_driver.c:407:22: warning: assignment to 'struct device_node *' from 'int' makes pointer from integer without a cast [-Wint-conversion] 407 | eth_ports_np = of_get_child_by_name(pdev->dev.of_node, "ethernet-ports"); | ^ >> drivers/net/ethernet/sunplus/spl2sw_driver.c:428:26: error: implicit declaration of function 'of_parse_phandle' [-Werror=implicit-function-declaration] 428 | phy_np = of_parse_phandle(port_np, "phy-handle", 0); | ^~~~~~~~~~~~~~~~ drivers/net/ethernet/sunplus/spl2sw_driver.c:428:24: warning: assignment to 'struct device_node *' from 'int' makes pointer from integer without a cast [-Wint-conversion] 428 | phy_np = of_parse_phandle(port_np, "phy-handle", 0); | ^ cc1: some warnings being treated as errors Kconfig warnings: (for reference only) WARNING: unmet direct dependencies detected for PINCTRL_SPPCTL Depends on PINCTRL && SOC_SP7021 && OF && HAS_IOMEM Selected by - SP7021_EMAC && NETDEVICES && ETHERNET && NET_VENDOR_SUNPLUS && (SOC_SP7021 || COMPILE_TEST vim +328 drivers/net/ethernet/sunplus/spl2sw_driver.c 322 323 static struct device_node *spl2sw_get_eth_child_node(struct device_node *ether_np, int id) 324 { 325 struct device_node *port_np; 326 int port_id; 327 > 328 for_each_child_of_node(ether_np, port_np) { 329 /* It is not a 'port' node, continue. */ 330 if (strcmp(port_np->name, "port")) 331 continue; 332 333 if (of_property_read_u32(port_np, "reg", &port_id) < 0) 334 continue; 335 336 if (port_id == id) 337 return port_np; 338 } 339 340 /* Not found! */ 341 return NULL; 342 } 343 344 static int spl2sw_probe(struct platform_device *pdev) 345 { 346 struct device_node *eth_ports_np; 347 struct device_node *port_np; 348 struct spl2sw_common *comm; 349 struct device_node *phy_np; 350 phy_interface_t phy_mode; 351 struct net_device *ndev; 352 u8 mac_addr[ETH_ALEN]; 353 struct spl2sw_mac *mac; 354 int irq, i; 355 int ret; 356 357 if (platform_get_drvdata(pdev)) 358 return -ENODEV; 359 360 /* Allocate memory for 'spl2sw_common' area. */ 361 comm = devm_kzalloc(&pdev->dev, sizeof(*comm), GFP_KERNEL); 362 if (!comm) 363 return -ENOMEM; 364 comm->pdev = pdev; 365 366 spin_lock_init(&comm->rx_lock); 367 spin_lock_init(&comm->tx_lock); 368 spin_lock_init(&comm->mdio_lock); 369 370 /* Get memory resource 0 from dts. */ 371 comm->l2sw_reg_base = devm_platform_ioremap_resource(pdev, 0); 372 if (IS_ERR(comm->l2sw_reg_base)) 373 return PTR_ERR(comm->l2sw_reg_base); 374 375 /* Get irq resource from dts. */ 376 ret = platform_get_irq(pdev, 0); 377 if (ret < 0) 378 return ret; 379 irq = ret; 380 381 /* Get clock controller. */ 382 comm->clk = devm_clk_get(&pdev->dev, NULL); 383 if (IS_ERR(comm->clk)) { 384 dev_err_probe(&pdev->dev, PTR_ERR(comm->clk), 385 "Failed to retrieve clock controller!\n"); 386 return PTR_ERR(comm->clk); 387 } 388 389 /* Get reset controller. */ 390 comm->rstc = devm_reset_control_get_exclusive(&pdev->dev, NULL); 391 if (IS_ERR(comm->rstc)) { 392 dev_err_probe(&pdev->dev, PTR_ERR(comm->rstc), 393 "Failed to retrieve reset controller!\n"); 394 return PTR_ERR(comm->rstc); 395 } 396 397 /* Enable clock. */ 398 clk_prepare_enable(comm->clk); 399 udelay(1); 400 401 reset_control_assert(comm->rstc); 402 udelay(1); 403 reset_control_deassert(comm->rstc); 404 udelay(1); 405 406 /* Get child node ethernet-ports. */ > 407 eth_ports_np = of_get_child_by_name(pdev->dev.of_node, "ethernet-ports"); 408 if (!eth_ports_np) { 409 dev_err(&pdev->dev, "No ethernet-ports child node found!\n"); 410 ret = -ENODEV; 411 goto out_clk_disable; 412 } 413 414 for (i = 0; i < MAX_NETDEV_NUM; i++) { 415 /* Get port@i of node ethernet-ports. */ 416 port_np = spl2sw_get_eth_child_node(eth_ports_np, i); 417 if (!port_np) 418 continue; 419 420 /* Get phy-mode. */ 421 if (of_get_phy_mode(port_np, &phy_mode)) { 422 dev_err(&pdev->dev, "Failed to get phy-mode property of port@%d!\n", 423 i); 424 continue; 425 } 426 427 /* Get phy-handle. */ > 428 phy_np = of_parse_phandle(port_np, "phy-handle", 0); 429 if (!phy_np) { 430 dev_err(&pdev->dev, "Failed to get phy-handle property of port@%d!\n", 431 i); 432 continue; 433 } 434 435 /* Get mac-address from nvmem. */ 436 ret = spl2sw_nvmem_get_mac_address(&pdev->dev, port_np, mac_addr); 437 if (ret) { 438 dev_info(&pdev->dev, "Generate a random mac address!\n"); 439 440 /* Generate a mac address using OUI of Sunplus Technology 441 * and random controller number. 442 */ 443 mac_addr[0] = 0xfc; /* OUI of Sunplus: fc:4b:bc */ 444 mac_addr[1] = 0x4b; 445 mac_addr[2] = 0xbc; 446 mac_addr[3] = get_random_int() % 256; 447 mac_addr[4] = get_random_int() % 256; 448 mac_addr[5] = get_random_int() % 256; 449 } 450 451 /* Initialize the net device. */ 452 ret = spl2sw_init_netdev(pdev, mac_addr, &ndev); 453 if (ret) 454 goto out_unregister_dev; 455 456 ndev->irq = irq; 457 comm->ndev[i] = ndev; 458 mac = netdev_priv(ndev); 459 mac->phy_node = phy_np; 460 mac->phy_mode = phy_mode; 461 mac->comm = comm; 462 463 mac->lan_port = 0x1 << i; /* forward to port i */ 464 mac->to_vlan = 0x1 << i; /* vlan group: i */ 465 mac->vlan_id = i; /* vlan group: i */ 466 467 /* Set MAC address */ 468 ret = spl2sw_mac_addr_add(mac); 469 if (ret) 470 goto out_unregister_dev; 471 472 spl2sw_mac_rx_mode_set(mac); 473 } 474 475 /* Find first valid net device. */ 476 for (i = 0; i < MAX_NETDEV_NUM; i++) { 477 if (comm->ndev[i]) 478 break; 479 } 480 if (i >= MAX_NETDEV_NUM) { 481 dev_err(&pdev->dev, "No valid ethernet port!\n"); 482 ret = -ENODEV; 483 goto out_clk_disable; 484 } 485 486 /* Save first valid net device */ 487 ndev = comm->ndev[i]; 488 platform_set_drvdata(pdev, ndev); 489 490 /* Request irq. */ 491 ret = devm_request_irq(&pdev->dev, irq, spl2sw_ethernet_interrupt, 492 0, ndev->name, ndev); 493 if (ret) { 494 netdev_err(ndev, "Failed to request irq #%d for \"%s\"!\n", 495 irq, ndev->name); 496 goto out_unregister_dev; 497 } 498 499 /* Initialize mdio bus */ 500 ret = spl2sw_mdio_init(comm); 501 if (ret) { 502 netdev_err(ndev, "Failed to initialize mdio bus!\n"); 503 goto out_unregister_dev; 504 } 505 506 ret = spl2sw_mac_addr_del_all(comm); 507 if (ret) 508 goto out_free_mdio; 509 510 ret = spl2sw_descs_init(comm); 511 if (ret) { 512 dev_err(&comm->pdev->dev, "Fail to initialize mac descriptors!\n"); 513 spl2sw_descs_free(comm); 514 goto out_free_mdio; 515 } 516 517 spl2sw_mac_init(comm); 518 519 ret = spl2sw_phy_connect(comm); 520 if (ret) { 521 netdev_err(ndev, "Failed to connect phy!\n"); 522 goto out_free_mdio; 523 } 524 525 netif_napi_add(ndev, &comm->rx_napi, spl2sw_rx_poll, SPL2SW_RX_NAPI_WEIGHT); 526 napi_enable(&comm->rx_napi); 527 netif_napi_add(ndev, &comm->tx_napi, spl2sw_tx_poll, SPL2SW_TX_NAPI_WEIGHT); 528 napi_enable(&comm->tx_napi); 529 return 0; 530 531 out_free_mdio: 532 spl2sw_mdio_remove(comm); 533 534 out_unregister_dev: 535 for (i = 0; i < MAX_NETDEV_NUM; i++) 536 if (comm->ndev[i]) 537 unregister_netdev(comm->ndev[i]); 538 539 out_clk_disable: 540 clk_disable_unprepare(comm->clk); 541 return ret; 542 } 543 -- 0-DAY CI Kernel Test Service https://01.org/lkp
