Re: [PATCH v3] arm64: dts: qcom: sc7280: Add WCN6750 WiFi node

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Tue, Apr 05, 2022 at 12:00:11PM +0530, Manikanta Pubbisetty wrote:
> On 4/5/2022 11:56 AM, Manikanta Pubbisetty wrote:
> > 
> > 
> > On 4/5/2022 12:59 AM, Matthias Kaehlcke wrote:
> > > On Mon, Mar 28, 2022 at 12:40:57PM +0530, Manikanta Pubbisetty wrote:
> > > > Add DTS node for WCN6750 WiFi chipset.
> > > > 
> > > > Signed-off-by: Manikanta Pubbisetty <quic_mpubbise@xxxxxxxxxxx>
> > > > ---
> > > > Depends on:
> > > > - https://patchwork.kernel.org/project/linux-arm-msm/patch/20220328070701.28551-1-quic_mpubbise@xxxxxxxxxxx/
> > > > 
> > > > - https://patchwork.kernel.org/project/linux-wireless/patch/20220328060937.16738-2-quic_mpubbise@xxxxxxxxxxx/
> > > > 
> > > > 
> > > > Changes from V2:
> > > > - Changes based on DT binding concerns
> > > > - Rebased on ToT
> > > > 
> > > > Changes from V1:
> > > > - Corrected the case for hex values
> > > > 
> > > >   arch/arm64/boot/dts/qcom/sc7280-idp.dtsi |  7 ++++
> > > >   arch/arm64/boot/dts/qcom/sc7280.dtsi     | 46 ++++++++++++++++++++++++
> > > >   2 files changed, 53 insertions(+)
> > > > 
> > > > diff --git a/arch/arm64/boot/dts/qcom/sc7280-idp.dtsi
> > > > b/arch/arm64/boot/dts/qcom/sc7280-idp.dtsi
> > > > index 069ffbc37bc4..a82e9aa7bdc5 100644
> > > > --- a/arch/arm64/boot/dts/qcom/sc7280-idp.dtsi
> > > > +++ b/arch/arm64/boot/dts/qcom/sc7280-idp.dtsi
> > > > @@ -551,3 +551,10 @@ &remoteproc_wpss {
> > > >       status = "okay";
> > > >   };
> > > > +&wifi {
> > > > +    status = "okay";
> > > > +    wifi-firmware {
> > > > +        iommus = <&apps_smmu 0x1c02 0x1>;
> > > > +    };
> > > > +};
> > > > +
> > > > diff --git a/arch/arm64/boot/dts/qcom/sc7280.dtsi
> > > > b/arch/arm64/boot/dts/qcom/sc7280.dtsi
> > > > index b757e8ad1199..dfd9fa077903 100644
> > > > --- a/arch/arm64/boot/dts/qcom/sc7280.dtsi
> > > > +++ b/arch/arm64/boot/dts/qcom/sc7280.dtsi
> > > > @@ -85,6 +85,11 @@ reserved-memory {
> > > >           #size-cells = <2>;
> > > >           ranges;
> > > > +        wlan_ce_mem: memory@4cd000 {
> > > > +            no-map;
> > > > +            reg = <0x0 0x4cd000 0x0 0x1000>;
> > > 
> > > Pad the address to 8 digits here (not in the node name).
> > 
> > Sure
> > 
> > > 
> > > > +        };
> > > > +
> > > >           hyp_mem: memory@80000000 {
> > > >               reg = <0x0 0x80000000 0x0 0x600000>;
> > > >               no-map;
> > > > @@ -1808,6 +1813,47 @@ mmss_noc: interconnect@1740000 {
> > > >               qcom,bcm-voters = <&apps_bcm_voter>;
> > > >           };
> > > > +        wifi: wifi@17a10040 {
> > > > +            compatible = "qcom,wcn6750-wifi";
> > > > +            reg = <0 0x17a10040 0 0x0>;
> > > > +            iommus = <&apps_smmu 0x1c00 0x1>;
> > > > +            interrupts = <GIC_SPI 768 IRQ_TYPE_EDGE_RISING>,
> > > > +                     <GIC_SPI 769 IRQ_TYPE_EDGE_RISING>,
> > > > +                     <GIC_SPI 770 IRQ_TYPE_EDGE_RISING>,
> > > > +                     <GIC_SPI 771 IRQ_TYPE_EDGE_RISING>,
> > > > +                     <GIC_SPI 772 IRQ_TYPE_EDGE_RISING>,
> > > > +                     <GIC_SPI 773 IRQ_TYPE_EDGE_RISING>,
> > > > +                     <GIC_SPI 774 IRQ_TYPE_EDGE_RISING>,
> > > > +                     <GIC_SPI 775 IRQ_TYPE_EDGE_RISING>,
> > > > +                     <GIC_SPI 776 IRQ_TYPE_EDGE_RISING>,
> > > > +                     <GIC_SPI 777 IRQ_TYPE_EDGE_RISING>,
> > > > +                     <GIC_SPI 778 IRQ_TYPE_EDGE_RISING>,
> > > > +                     <GIC_SPI 779 IRQ_TYPE_EDGE_RISING>,
> > > > +                     <GIC_SPI 780 IRQ_TYPE_EDGE_RISING>,
> > > > +                     <GIC_SPI 781 IRQ_TYPE_EDGE_RISING>,
> > > > +                     <GIC_SPI 782 IRQ_TYPE_EDGE_RISING>,
> > > > +                     <GIC_SPI 783 IRQ_TYPE_EDGE_RISING>,
> > > > +                     <GIC_SPI 784 IRQ_TYPE_EDGE_RISING>,
> > > > +                     <GIC_SPI 785 IRQ_TYPE_EDGE_RISING>,
> > > > +                     <GIC_SPI 786 IRQ_TYPE_EDGE_RISING>,
> > > > +                     <GIC_SPI 787 IRQ_TYPE_EDGE_RISING>,
> > > > +                     <GIC_SPI 788 IRQ_TYPE_EDGE_RISING>,
> > > > +                     <GIC_SPI 789 IRQ_TYPE_EDGE_RISING>,
> > > > +                     <GIC_SPI 790 IRQ_TYPE_EDGE_RISING>,
> > > > +                     <GIC_SPI 791 IRQ_TYPE_EDGE_RISING>,
> > > > +                     <GIC_SPI 792 IRQ_TYPE_EDGE_RISING>,
> > > > +                     <GIC_SPI 793 IRQ_TYPE_EDGE_RISING>,
> > > > +                     <GIC_SPI 794 IRQ_TYPE_EDGE_RISING>,
> > > > +                     <GIC_SPI 795 IRQ_TYPE_EDGE_RISING>,
> > > > +                     <GIC_SPI 796 IRQ_TYPE_EDGE_RISING>,
> > > > +                     <GIC_SPI 797 IRQ_TYPE_EDGE_RISING>,
> > > > +                     <GIC_SPI 798 IRQ_TYPE_EDGE_RISING>,
> > > > +                     <GIC_SPI 799 IRQ_TYPE_EDGE_RISING>;
> > > > +            qcom,rproc = <&remoteproc_wpss>;
> > > > +            memory-region = <&wlan_fw_mem>, <&wlan_ce_mem>;
> > > 
> > > Where is 'wlan_fw_mem' added?
> > 
> > Sorry, did not understand your concern here.
> > 
> 
> Well, I got your point. wlan_fw_mem is already present in SC7280.dtsi.

Sorry, I thought I had grepped for it and didn't find it, but now I see
it's there.



[Index of Archives]     [Device Tree Compilter]     [Device Tree Spec]     [Linux Driver Backports]     [Video for Linux]     [Linux USB Devel]     [Linux PCI Devel]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [XFree86]     [Yosemite Backpacking]


  Powered by Linux