On 03/04/2022 17:45, Chuanhong Guo wrote:
> Hi!
>
> On Sun, Apr 3, 2022 at 11:37 PM Krzysztof Kozlowski
> <krzysztof.kozlowski@xxxxxxxxxx> wrote:
>> [...]
>>> + compatible:
>>> + enum:
>>> + - mediatek,mt7622-snand
>>> + - mediatek,mt7629-snand
>>
>> One blank line, please.
>
> I'll fix this in the next version.
>
>>
>>> + reg:
>>> + items:
>>> + - description: core registers
>>> +
>>> + interrupts:
>>> + items:
>>> + - description: NFI interrupt
>>> +
>>> + clocks:
>>> + items:
>>> + - description: clock used for the controller
>>> + - description: clock used for the SPI bus
>>> +
>>> + clock-names:
>>> + items:
>>> + - const: nfi_clk
>>> + - const: pad_clk
>>> +
>>> + ecc-engine:
>>
>> The nand-chip.yaml defines a nand-ecc-engine, so how about using that
>> one? I know mtk-nand.txt uses ecc-engine, but for new schema better to
>> use properties from existing YAML.
>
> The ecc-engine code is shared between mtk_nand.c and this driver, and
> the property name is defined in the shared part. I left it as-is so that
> existing dt for mtk_nand doesn't break.
This can be easily fixed with:
np = of_parse_phandle(of_node, "nand-ecc-engine", 0);
if (!np) {
/* Backwards compatible */
np = of_parse_phandle(of_node, "ecc-engine", 0);
}
I would like to avoid having one property in generic NAND schema and
keep adding something slightly different everywhere else.
Best regards,
Krzysztof
