Le Sat, Apr 02, 2022 at 02:10:21PM +0200, Krzysztof Kozlowski a écrit : > On 01/04/2022 22:17, Corentin Labbe wrote: > > Convert rockchip-crypto to yaml > > s/yaml/YAML/ > and a full stop. > > Looks good but please mention in commit msg that the names for clocks > and resets will be provided in next patch. Otherwise it looks like > incomplete conversion. Hello I forgot clock-names in this patch, i will fix that (and other comments) in v5. Thanks > > > > > Signed-off-by: Corentin Labbe <clabbe@xxxxxxxxxxxx> > > --- > > .../crypto/rockchip,rk3288-crypto.yaml | 59 +++++++++++++++++++ > > .../bindings/crypto/rockchip-crypto.txt | 28 --------- > > 2 files changed, 59 insertions(+), 28 deletions(-) > > create mode 100644 Documentation/devicetree/bindings/crypto/rockchip,rk3288-crypto.yaml > > delete mode 100644 Documentation/devicetree/bindings/crypto/rockchip-crypto.txt > > > > diff --git a/Documentation/devicetree/bindings/crypto/rockchip,rk3288-crypto.yaml b/Documentation/devicetree/bindings/crypto/rockchip,rk3288-crypto.yaml > > new file mode 100644 > > index 000000000000..66db671118c3 > > --- /dev/null > > +++ b/Documentation/devicetree/bindings/crypto/rockchip,rk3288-crypto.yaml > > @@ -0,0 +1,59 @@ > > +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) > > +%YAML 1.2 > > +--- > > +$id: http://devicetree.org/schemas/crypto/rockchip,rk3288-crypto.yaml# > > +$schema: http://devicetree.org/meta-schemas/core.yaml# > > + > > +title: Rockchip Electronics And Security Accelerator > > Remove "And". It looks like company name is the name of the hardware. > > Best regards, > Krzysztof